Skip to content

Commit 4634aba

Browse files
authored
add default for owner parameter of pyqtSignal.__get__() (#199)
https://github.com/python-qt-tools/PyQt5-stubs/actions/runs/3485949394/jobs/5831945350#step:7:111 > `error: PyQt5.QtCore.pyqtSignal.__get__ is inconsistent, runtime argument "owner" has a default value but stub argument does not`
2 parents 35a6af9 + 7ae6ad5 commit 4634aba

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

PyQt5-stubs/QtCore.pyi

+11-4
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,18 @@ class pyqtSignal:
5555

5656
def __init__(self, *types: typing.Any, name: str = ...) -> None: ...
5757

58-
@typing.overload
59-
def __get__(self, instance: None, owner: typing.Type["QObject"]) -> "pyqtSignal": ...
58+
if sys.version_info >= (3, 10):
59+
@typing.overload
60+
def __get__(self, instance: None, owner: typing.Optional[typing.Type["QObject"]] = ...) -> "pyqtSignal": ...
6061

61-
@typing.overload
62-
def __get__(self, instance: "QObject", owner: typing.Type["QObject"]) -> pyqtBoundSignal: ...
62+
@typing.overload
63+
def __get__(self, instance: "QObject", owner: typing.Optional[typing.Type["QObject"]] = ...) -> pyqtBoundSignal: ...
64+
else:
65+
@typing.overload
66+
def __get__(self, instance: None, owner: typing.Type["QObject"]) -> "pyqtSignal": ...
67+
68+
@typing.overload
69+
def __get__(self, instance: "QObject", owner: typing.Type["QObject"]) -> pyqtBoundSignal: ...
6370

6471

6572
# Convenient type aliases.

0 commit comments

Comments
 (0)