From 9c2cb9a14a221239270d6e10424cf0090494a33b Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 5 Oct 2020 09:35:40 +0200 Subject: [PATCH] bpo-41939: Fix test_site.test_license_exists_at_url() Call urllib.request.urlcleanup() to reset the global urllib.request._opener. --- Lib/test/test_site.py | 2 ++ .../NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst diff --git a/Lib/test/test_site.py b/Lib/test/test_site.py index d3ee68facdbc3d..a475ed1ab4c469 100644 --- a/Lib/test/test_site.py +++ b/Lib/test/test_site.py @@ -525,6 +525,8 @@ def test_license_exists_at_url(self): # string displayed by license in the absence of a LICENSE file. url = license._Printer__data.split()[1] req = urllib.request.Request(url, method='HEAD') + # Reset global urllib.request._opener + self.addCleanup(urllib.request.urlcleanup) try: with socket_helper.transient_internet(url): with urllib.request.urlopen(req) as data: diff --git a/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst b/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst new file mode 100644 index 00000000000000..e58ad2616da1ba --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst @@ -0,0 +1,3 @@ +Fix test_site.test_license_exists_at_url(): call +``urllib.request.urlcleanup()`` to reset the global +``urllib.request._opener``. Patch by Victor Stinner.