Skip to content

Release 0.610 planning #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msullivan opened this issue May 22, 2018 · 18 comments
Closed

Release 0.610 planning #5096

msullivan opened this issue May 22, 2018 · 18 comments
Assignees

Comments

@msullivan
Copy link
Collaborator

msullivan commented May 22, 2018

I'd like to release mypy 0.610 on Friday June 8. Aiming to cut the release branch on Tuesday May 29.

If there are any PRs that urgently need merged, mention them here.

@msullivan msullivan self-assigned this May 22, 2018
@gvanrossum
Copy link
Member

gvanrossum commented May 22, 2018

So we definitely need to do something about google/protobuf in typeshed (python/typeshed#2154), i.e. PR python/typeshed#2157 (now merged into master).

@msullivan
Copy link
Collaborator Author

Actually we're gonna cut the release branch on Tuesday, because Monday is a holiday in the United States

@msullivan
Copy link
Collaborator Author

Going to cut the release branch today, but postponing the release until Monday

@msullivan
Copy link
Collaborator Author

Release branch is cut, with a cherry pick to include #5120 but exclude #5084.

I have a documentation patch about dmypy run that I intend to write and cherry-pick. I don't think we have any other planned cherry picks?

@ilevkivskyi
Copy link
Member

Release branch is cut, with a cherry pick to include #5120 but exclude #5084.

👍 Perfect!

@JelleZijlstra
Copy link
Member

#5122 should be a release blocker.

@ilevkivskyi
Copy link
Member

Hm, I think I can fix it. I reviewed the PR that likely causes this.

@JelleZijlstra
Copy link
Member

Thanks for fixing that one! I just checked our codebase against master again and got a few other errors: #5124 (almost certainly related to the overload refactor that won't go into 0.610) and a false positive about an incompatible return type on an async method with a decorator, which I haven't had time to minimize yet.

@ilevkivskyi
Copy link
Member

Overload PR is not in the release branch, see above. I am much more interested in

a false positive about an incompatible return type on an async method with a decorator

Because this one is in the release branch.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 30, 2018

#5125.

[Edit: this might not be a bug and doesn't need to block the release.]

@msullivan
Copy link
Collaborator Author

#5123 cherry-picked

@msullivan
Copy link
Collaborator Author

msullivan commented May 31, 2018

Oh and #5053 should be probably done

@msullivan
Copy link
Collaborator Author

OK since the pace of things that we need to cherry-pick has been continuing unabated all week, I am postponing the release another week so that we can validate it more.
I plan to cherry-pick #5132 and #5126, and then we will hopefully have an actual "release candidate".
(Though there will still be a documentation patch I need to write and cherry-pick.)

@msullivan
Copy link
Collaborator Author

I believe that f3cb59a is now a release candidate.

@msullivan
Copy link
Collaborator Author

Cherry picking the documentation patch #5157

@msullivan
Copy link
Collaborator Author

msullivan commented Jun 7, 2018

Cherry picked the documentation patch #5164

@msullivan
Copy link
Collaborator Author

Release out!

@timwraight
Copy link

Just wanted to say what a massive difference 0.610 has made to my daily workflow. Having flycheck on emacs run dmypy run instead of mypy check is like night and day, and has made day to day coding so much more enjoyable. Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants