Skip to content

Plug the exact count optimization #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fulmicoton opened this issue Oct 20, 2023 · 0 comments · Fixed by #4019
Closed

Plug the exact count optimization #3997

fulmicoton opened this issue Oct 20, 2023 · 0 comments · Fixed by #4019
Assignees
Labels
enhancement New feature or request

Comments

@fulmicoton
Copy link
Collaborator

fulmicoton commented Oct 20, 2023

We recently added an optimization for top K sorted by time.
We process splits in the most promising order in order.

Once we have saturated the order, if a the split metadata informs us that we cannot hope for better results, we currently set max_hits to 0 which has the great side-effect of removing the need to warmup the timestamp fields.

We however still perform search, because to count the documents.

It would be interesting to add an enum property to the search proto to make it possible to remove the need to process the split entirely, (in the absenve of any aggregations of course)

Disclaimer

Let's not break backward compatibility. Hence the idea of using an enum, which would give us more control on what the default value should be in the absence of a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants