Skip to content

Small improvements on the ES field cap endpoint #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 of 10 tasks
fmassot opened this issue Dec 18, 2023 · 5 comments
Open
7 of 10 tasks

Small improvements on the ES field cap endpoint #4298

fmassot opened this issue Dec 18, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@fmassot
Copy link
Collaborator

fmassot commented Dec 18, 2023

  • if one of the index patterns doesn’t match anything, we should return a 200: we should call check_all_index_metadata_found method in the root function (as it's done for a classic search endpoint
  • return undocumented type value
  • /_field_caps URL

Query Parameters

  • fields
  • allow_no_indices (ignored)
  • expand_wildcards (ignored)
  • accept ignore_unavailable query parameter and ignore it silently
  • include_unmapped parameter
  • types parameter
  • filters parameter
@fmassot fmassot added the enhancement New feature or request label Dec 18, 2023
@fmassot fmassot changed the title Small improvements on the ES field caps endpoint Small improvements on the ES field cap endpoint Dec 18, 2023
@PSeitz
Copy link
Collaborator

PSeitz commented Dec 19, 2023

add a test for the URL _field_caps?=* to catch regression on this one

What regression? _field_caps?=* is an invalid url and returns an error

@fmassot
Copy link
Collaborator Author

fmassot commented Dec 19, 2023

@PSeitz yes indeed, we need to fix this.

@PSeitz
Copy link
Collaborator

PSeitz commented Dec 19, 2023

@PSeitz yes indeed, we need to fix this.

What needs to be fixed?

@fmassot
Copy link
Collaborator Author

fmassot commented Dec 29, 2023

It would be nice to be able to limit the number of splits we scan.

I see 2 options: limit the number of splits to 1000 by default or to a time window (last 30 days for example).

@PSeitz
Copy link
Collaborator

PSeitz commented Jan 5, 2024

Related Issues
#3527
#4242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants