Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "deps::." optional in setup-r-dependencies #486

Closed
assignUser opened this issue Jan 25, 2022 · 10 comments
Closed

Make "deps::." optional in setup-r-dependencies #486

assignUser opened this issue Jan 25, 2022 · 10 comments
Labels
feature a feature request or enhancement

Comments

@assignUser
Copy link

Hello!
The new v2 actions are awesome! Thanks for the great work :)

I tried using setup-r-dependencies in a repo that is not a package but rather an action using R. The setup fail due too deps::. not finding a local package-
image

It would be nice if I could turn of installation of local dependencies, for now I am going to create a dummy package as a workaround.

@gaborcsardi
Copy link
Member

Well, it is called setup-r-dependencies. :) So what do you want to install instead? Maybe we should have an install-r-packages action?

@assignUser
Copy link
Author

True :D. That would be s solution but I can't think of any functionality that would be needed other than not using deps::.. but if you want to do it in a separate action I would be happy to use it 😁

@gaborcsardi
Copy link
Member

OK, how about having a packages argument, which defaults to "deps::."?

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Jan 26, 2022
@assignUser
Copy link
Author

That would be perfect 😄

@gaborcsardi
Copy link
Member

Can you try if @v2-branch works for you?

@assignUser
Copy link
Author

@gaborcsardi yep works perfectly: https://github.com/ropensci-review-tools/pkgcheck-action/runs/4965427019?check_suite_focus=true#step:4:65

Thank you for implementing this so quickly!

@gaborcsardi
Copy link
Member

I'll merge it it @v2 soon, I'll comment here. Then it is best to revert back to @v2 because @v2-branch has experimental stuff sometimes.

@gaborcsardi
Copy link
Member

This is now in v2.

@assignUser
Copy link
Author

Awesome, thank you @gaborcsardi !

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants