Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning #367

Closed
ilikegitlab opened this issue Mar 16, 2024 · 3 comments
Closed

deprecation warning #367

ilikegitlab opened this issue Mar 16, 2024 · 3 comments

Comments

@ilikegitlab
Copy link

After a recent update of ggplot2:

data.frame(a=c(1,2,3),b=set_units(c(4,4,3),"m")) |> ggplot() + geom_point(aes(a,b))
Warning message:
The scale_name argument of continuous_scale() is deprecated as of ggplot2 3.5.0.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.

I only get this when using units.

@edzer edzer closed this as completed in 787263d Mar 16, 2024
@edzer
Copy link
Member

edzer commented Mar 16, 2024

Thanks!

@edzer
Copy link
Member

edzer commented Mar 16, 2024

@Enchufa2 this seems to break quantities checks in GA, but that might well be false negatives?

@Enchufa2
Copy link
Member

@Enchufa2 this seems to break quantities checks in GA, but that might well be false negatives?

Sorry, didn't see this message. Kind of. A ggplot2 test fails because the resulting SVG is a little different, but there's no visual difference. I updated the test in quantities and pinned it to this version of units, but we'll need to release quantities before units the next time to avoid CRAN issues. No big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants