Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report/Feature request portals inside a centralized Help page #133

Merged
merged 6 commits into from
Oct 18, 2020

Conversation

BryceCallender
Copy link
Collaborator

Description

Built a means for a user to submit bug reports and request features. These will be sent from the site to our GitHub issues directly without having to have a user come to the GitHub and request it. This is done through means of a bot and GitHub's API to send data from the site as a issue with its respective tags. The bug request form is expecting a title, description, and steps to reproduce that will be transferred to make it easier for us to try to reproduce the bugs and know more about them. Feature request is mainly just a title and description then we can decide on it from there. Updated _Layout since I needed jQuery reference at the top in order to use form validation in my .cshtml files for bug and feature. Added toasts for when the user submits or has an error during the form process. The two things that could possibly happen is the GitHub token is incorrect/invalid or the spelling of the user/repo is incorrect. The errors tell the user to notify us if that is the case.

Motivation and Context

This allows users to give us feedback and help fix the site without having to directly come into GitHub and logging in just to request or report bugs. This gives them a easy user experience which also gives us detailed information in order to check if its a browser issue and what version the site is using!

Resolves #119

How Has This Been Tested?

Manually tested. Tested the bug/feature reports on my own repo for the images.

Screenshots (if appropriate):

bug
feature
submit_error

(I missed the Issue # 12 in this screenshot, so ignore that)
github_issues

(was on a different version for both below)
bug_stuff

feature_stuff

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit and integration tests to cover my changes.
  • All new and existing tests passed.
  • I updated the SamVer in the appropriate .csproj file (only for to-master-merges, ask rbaker26 for a release number).

Sorry, something went wrong.

@github-actions
Copy link

BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon Platinum 8171M CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.403
  [Host]     : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT
  DefaultJob : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT

Method Mean Error StdDev Ratio RatioSD
EngineRun_HLT 153.2 μs 1.54 μs 1.44 μs 1.00 0.00
EngineRun_LDA170 175.1 μs 1.55 μs 1.29 μs 1.14 0.02
EngineRun_FIB5 966.8 μs 4.96 μs 3.88 μs 6.32 0.07

@rbaker26 rbaker26 added API enhancement New feature or request GUI Improvements or additions to GUI labels Oct 17, 2020
@rbaker26 rbaker26 added this to the v3.0.0-rc milestone Oct 17, 2020
@rbaker26 rbaker26 linked an issue Oct 17, 2020 that may be closed by this pull request
3 tasks
@rbaker26 rbaker26 self-assigned this Oct 17, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
trying to retrigger GitHub Actions
@github-actions
Copy link

BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon Platinum 8171M CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.403
  [Host]     : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT
  DefaultJob : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT

Method Mean Error StdDev Ratio RatioSD
EngineRun_HLT 122.3 μs 2.41 μs 3.53 μs 1.00 0.00
EngineRun_LDA170 138.4 μs 2.75 μs 3.76 μs 1.13 0.05
EngineRun_FIB5 795.1 μs 15.11 μs 15.52 μs 6.49 0.18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #133 into v3.0.0-rc will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v3.0.0-rc     #133   +/-   ##
==========================================
  Coverage      87.10%   87.10%           
==========================================
  Files             28       28           
  Lines           1272     1272           
==========================================
  Hits            1108     1108           
  Misses           164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5247b...ed9046c. Read the comment docs.

@github-actions
Copy link

BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon Platinum 8171M CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.403
  [Host]     : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT
  DefaultJob : .NET Core 3.1.9 (CoreCLR 4.700.20.47201, CoreFX 4.700.20.47203), X64 RyuJIT

Method Mean Error StdDev Ratio RatioSD
EngineRun_HLT 141.1 μs 0.80 μs 0.75 μs 1.00 0.00
EngineRun_LDA170 161.4 μs 1.04 μs 0.98 μs 1.14 0.01
EngineRun_FIB5 899.7 μs 2.80 μs 2.34 μs 6.38 0.04

@rbaker26 rbaker26 merged commit f9594cf into v3.0.0-rc Oct 18, 2020
@BryceCallender BryceCallender deleted the BugFeatureRequest branch October 18, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request GUI Improvements or additions to GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] - Ticket Portal GitHub API in WebApp
3 participants