You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we import several specific types from the redux core package. I actually was about to say "we have a hard dependency on the redux core", but I actually don't even see it listed as a dep, which makes me very suspicious about the v8 branch in its current form.
Anyway, we currently import these types: Action, AnyAction, Dispatch, Store, and ActionCreatorsMapObject.
We inlined our implementation of bindActionCeators a while back, but the types requirement means we still have a tie to the actual redux package.
Given our current discussion around discouraging use of redux by itself, as well as the various shenanigans with NPM, peerDeps, and redux vs @reduxjs/toolkit, I think we ought to look at inlining those types directly into the v8 codebase so that react-redux has 0 need to import anything from redux. This also goes along with the idea that any store-compatible object is legal to pass to <Provider>.
The text was updated successfully, but these errors were encountered:
Right now we import several specific types from the
redux
core package. I actually was about to say "we have a hard dependency on theredux
core", but I actually don't even see it listed as a dep, which makes me very suspicious about the v8 branch in its current form.Anyway, we currently import these types:
Action
,AnyAction
,Dispatch
,Store
, andActionCreatorsMapObject
.We inlined our implementation of
bindActionCeators
a while back, but the types requirement means we still have a tie to the actualredux
package.Given our current discussion around discouraging use of
redux
by itself, as well as the various shenanigans with NPM, peerDeps, andredux
vs@reduxjs/toolkit
, I think we ought to look at inlining those types directly into the v8 codebase so thatreact-redux
has 0 need to import anything fromredux
. This also goes along with the idea that any store-compatible object is legal to pass to<Provider>
.The text was updated successfully, but these errors were encountered: