Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move External BLE Sensor Selection to Settings #609

Closed
benswinburne opened this issue Jan 17, 2025 · 7 comments
Closed

[FEATURE] Move External BLE Sensor Selection to Settings #609

benswinburne opened this issue Jan 17, 2025 · 7 comments
Assignees

Comments

@benswinburne
Copy link

Daikin hardware
Faikin-S3-MINI-N4-R2: 9f65e5b 2024-11-30T08:32:55 S21

Is your feature request related to a problem? Please describe.

The web pages to control Faikin is exposed on my network, and also my guest network so users without access to home assistant can control the HVAC units. The BLE sensor selection is available on the homepage of the Faikin interface, not protected by the settings password. This allows any user on my network to choose the wrong temperature sensor on any HVAC page, i.e. the office HVAC could be pointed at the bedroom external sensor by a non admin user, resulting in the wrong temperatures being passed to the HVAC unit.

I struggled with this setting this up this initially - reading the docs was clear until the end where suddenly it just stops. I turned on BLE then was digging through settings trying to find where "The device will appear with its MAC address as its name." appeared. I assumed "BLE sensor ID" was supposed to change to a drop down. I wondered what ID meant in this context and ultimately didn't put the mac address in there.

I found the actual drop down by accident later on the homepage - then realised that this fills in the mac address in the ID field in settings.

Describe the solution you'd like

  • Move the BLE sensor selection to the BLE section in the settings to be password protected.
  • Rename the description of autob to External BLE Sensor MAC Address (Without : delimiters)
  • Move autob next to ble in settings
  • Update documentation in BLE
    • indicate you must turn on BLE
    • inform the reader they must select BLE device using the new dropdown (or from homepage if selection is not moved) or fill in autob with the mac address of the BLE device

Describe alternatives you've considered

Leave the BLE device dropdown on the homepage but make it read only. Make autob field the only way to set the value.

Additional context

As an aside, the process of updating the LYWSD03MMC devices is considerably more convoluted since the recent default firmware update which only accepts signed OTA updates MI Home. It's still very doable but might want to tweak your summary slightly?

Also, the custom firmware only offers "BTHome2" in terms of BTHome. Might want to add that you support BTHome and BTHome2 in the docs (Everything seems to be working on BTHome2, but as the docs didn't say it I spent time testing)

@revk
Copy link
Owner

revk commented Jan 18, 2025

Some good suggestions, I'll look in to it.

@revk
Copy link
Owner

revk commented Jan 18, 2025

The "ID" is only a MAC if no name provided, e.g. these are the IDs I see on my desk.

Image

@revk
Copy link
Owner

revk commented Jan 18, 2025

I'll put the pull down in the first settings page to make that easier.

Image

@revk
Copy link
Owner

revk commented Jan 18, 2025

I'll remove the whole Faikin-auto from main page if a password is set.

@revk
Copy link
Owner

revk commented Jan 18, 2025

OK try next beta, I think I have addressed your concerns.

@benswinburne
Copy link
Author

benswinburne commented Jan 18, 2025

The "ID" is only a MAC if no name provided, e.g. these are the IDs I see on my desk.

Image

Interesting, my dropdown only shows MAC addresses. The devices are all named (I see their names when scanning for BLE devices outside of Faikin). I am using the ATC_v49.bin firmware on the sensors.

Image

Which ends up in autob

Image

Updated to the beta firmware, dropdown has moved to behind password protected section so 👍

Thanks for the speedy turnaround, much appreciated.

@revk
Copy link
Owner

revk commented Jan 18, 2025

Yeh we don't do a secondary poll for a name so has to be in the basic advertisement. Else MAC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants