Skip to content

Commit a7cbf6c

Browse files
committed
maint/CICD ~ remove cargo fmt gating for 'windows'
- unneeded after reorg - but issue still remains; see GH:/rust-lang/rustfmt#3590
1 parent cc8a2be commit a7cbf6c

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

.github/workflows/CICD.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ jobs:
3434
shell: bash
3535
run: |
3636
## VARs setup
37-
# #maint: [rivy; 2020-02-08] 'windows-latest' `cargo fmt` is bugged for this project (see reasons @ GH:rust-lang/rustfmt #3324, #3590, #3688 ; waiting for repair)
38-
JOB_DO_FORMAT_TESTING="true"
39-
case '${{ matrix.job.os }}' in windows-latest) unset JOB_DO_FORMAT_TESTING ;; esac;
40-
echo set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING:-<empty>/false}
41-
echo ::set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING}
4237
# target-specific options
4338
# * CARGO_FEATURES_OPTION
4439
CARGO_FEATURES_OPTION='' ;
@@ -53,14 +48,12 @@ jobs:
5348
profile: minimal # minimal component installation (ie, no documentation)
5449
components: rustfmt, clippy
5550
- name: "`fmt` testing"
56-
if: steps.vars.outputs.JOB_DO_FORMAT_TESTING
5751
shell: bash
5852
run: |
5953
# `fmt` testing
6054
# * convert any warnings to GHA UI annotations; ref: <https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message>
6155
S=$(cargo fmt -- --check) && printf "%s\n" "$S" || { printf "%s\n" "$S" | sed -E -n -e "s/^Diff[[:space:]]+in[[:space:]]+${PWD//\//\\/}\/(.*)[[:space:]]+at[[:space:]]+[^0-9]+([0-9]+).*$/::warning file=\1,line=\2::WARNING: \`cargo fmt\`: style violation/p" ; }
6256
- name: "`fmt` testing of tests"
63-
if: steps.vars.outputs.JOB_DO_FORMAT_TESTING
6457
shell: bash
6558
run: |
6659
# `fmt` testing of tests

0 commit comments

Comments
 (0)