Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trinary micro_mod and growth are not completely implemented #88

Closed
YoelPH opened this issue Jun 24, 2024 · 4 comments
Closed

trinary micro_mod and growth are not completely implemented #88

YoelPH opened this issue Jun 24, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@YoelPH
Copy link
Contributor

YoelPH commented Jun 24, 2024

In unilateral the sharing of micro_mod and growth are not fully implemented.

Lines 89 -92 indicate that is_micro_mod_shared and is_growth_shared exist:

        The ``is_micro_mod_shared`` and ``is_growth_shared`` parameters determine
        whether the microscopic involvement and growth parameters are shared among all
        LNLs. If they are set to ``True``, the parameters are set globally for all LNLs.
        If they are set to ``False``, the parameters are set individually for each LNL.

For growth this is not needed. By nature we can set all growth parameters with growth. For the micro_mod this does not exist. Hence, is_micro_mod_shared should exist, or the key word micro_mod should be changing all micro_mod parameters.
Maybe I am missing something, but I did not find this function in the code.

@rmnldwg
Copy link
Owner

rmnldwg commented Jun 24, 2024

The documentation is definitely wrong here...

But isn't the micro mod parameter simply set by using set_params(micro=0.5)? It should be similar (or the same) as the growth parameter. But because we cannot have underscores in the parameter names anymore, I had to change its name to micro instead of micro_mod, I think.

Could you check if it does or doesn't share the micro globally?

@rmnldwg rmnldwg added the documentation Improvements or additions to documentation label Jun 24, 2024
@YoelPH
Copy link
Contributor Author

YoelPH commented Jun 24, 2024

Ahh, I was looking for micro_mod, since it was in the documentation. But then it makes sense. I will check it as soon as my sampling is done. If it works as you said, everything (except the documentation) is fine.

@YoelPH
Copy link
Contributor Author

YoelPH commented Jun 24, 2024

It works :) Can be closed

@rmnldwg
Copy link
Owner

rmnldwg commented Jun 24, 2024

I'll keep it open until the docs are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants