Skip to content

Rename SetDutyCycle::get_max_duty_cycle #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
madsmtm opened this issue Nov 21, 2023 · 1 comment · Fixed by #536
Closed

Rename SetDutyCycle::get_max_duty_cycle #524

madsmtm opened this issue Nov 21, 2023 · 1 comment · Fixed by #536
Milestone
v1.0.0

Comments

@madsmtm
Copy link

madsmtm commented Nov 21, 2023

The get_ prefix is discouraged as per the Rust API Guidelines, the method should be named max_duty_cycle.
@madsmtm madsmtm mentioned this issue Nov 21, 2023
Closed
@Dirbaio
Copy link
Member

Dirbaio commented Nov 22, 2023

LGTM, can you send a PR?

@Dirbaio Dirbaio added this to the v1.0.0 milestone Nov 28, 2023
@Dirbaio Dirbaio mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

pwm: rename get_max_duty_cycle to max_duty_cycle. Dirbaio/embedded-hal
2 participants
@Dirbaio @madsmtm