From 2c6f03d48bd25294187eca27c5357620f612c656 Mon Sep 17 00:00:00 2001 From: Serial <69764315+Serial-ATA@users.noreply.github.com> Date: Sun, 7 Nov 2021 14:28:30 -0500 Subject: [PATCH] Fix ICE in undocumented_unsafe_blocks --- clippy_lints/src/undocumented_unsafe_blocks.rs | 4 +++- tests/ui/crashes/auxiliary/ice-7934-aux.rs | 4 ++++ tests/ui/crashes/ice-7934.rs | 7 +++++++ 3 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 tests/ui/crashes/auxiliary/ice-7934-aux.rs create mode 100644 tests/ui/crashes/ice-7934.rs diff --git a/clippy_lints/src/undocumented_unsafe_blocks.rs b/clippy_lints/src/undocumented_unsafe_blocks.rs index 99b33e5433fb..fbf66712261e 100644 --- a/clippy_lints/src/undocumented_unsafe_blocks.rs +++ b/clippy_lints/src/undocumented_unsafe_blocks.rs @@ -149,6 +149,8 @@ impl UndocumentedUnsafeBlocks { let lex_end = (between_span.hi().0 - source_file.start_pos.0) as usize; let src_str = source_file.src.as_ref()?[lex_start..lex_end].to_string(); + let source_start_pos = source_file.start_pos.0 as usize + lex_start; + let mut pos = 0; let mut comment = false; @@ -171,7 +173,7 @@ impl UndocumentedUnsafeBlocks { if comment { // Get the line number of the "comment" (really wherever the trailing whitespace ended) let comment_line_num = source_file - .lookup_file_pos_with_col_display(BytePos((lex_start + pos).try_into().unwrap())) + .lookup_file_pos(BytePos((source_start_pos + pos).try_into().unwrap())) .0; // Find the block/local's line number let block_line_num = tcx.sess.source_map().lookup_char_pos(block_span.lo()).line; diff --git a/tests/ui/crashes/auxiliary/ice-7934-aux.rs b/tests/ui/crashes/auxiliary/ice-7934-aux.rs new file mode 100644 index 000000000000..4afbf027b61c --- /dev/null +++ b/tests/ui/crashes/auxiliary/ice-7934-aux.rs @@ -0,0 +1,4 @@ +fn zero() { + // SAFETY: + unsafe { 0 }; +} diff --git a/tests/ui/crashes/ice-7934.rs b/tests/ui/crashes/ice-7934.rs new file mode 100644 index 000000000000..a4691c4131b3 --- /dev/null +++ b/tests/ui/crashes/ice-7934.rs @@ -0,0 +1,7 @@ +#![warn(clippy::undocumented_unsafe_blocks)] +#![allow(clippy::no_effect)] + +#[path = "auxiliary/ice-7934-aux.rs"] +mod zero; + +fn main() {}