Use typeck_results to avoid duplicate ast_ty_to_ty call

compiler-errors · compiler-errors · commit d672fea64a59 · 2022-07-16T22:54:46.000Z
diff --git a/compiler/rustc_typeck/src/check/fn_ctxt/checks.rs b/compiler/rustc_typeck/src/check/fn_ctxt/checks.rs
@@ -1791,19 +1791,11 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                             .flat_map(|a| a.args.iter())
                         {
                             if let hir::GenericArg::Type(hir_ty) = &arg {
-                                if let hir::TyKind::Path(hir::QPath::TypeRelative(..)) =
-                                    &hir_ty.kind
-                                {
-                                    // Avoid ICE with associated types. As this is best
-                                    // effort only, it's ok to ignore the case. It
-                                    // would trigger in `is_send::<T::AssocType>();`
-                                    // from `typeck-default-trait-impl-assoc-type.rs`.
-                                } else {
-                                    let ty = <dyn AstConv<'_>>::ast_ty_to_ty(self, hir_ty);
-                                    let ty = self.resolve_vars_if_possible(ty);
-                                    if ty == predicate.self_ty() {
-                                        error.obligation.cause.span = hir_ty.span;
-                                    }
+                                let ty = self.resolve_vars_if_possible(
+                                    self.typeck_results.borrow().node_type(hir_ty.hir_id),
+                                );
+                                if ty == predicate.self_ty() {
+                                    error.obligation.cause.span = hir_ty.span;
                                 }
                             }
                         }
diff --git a/src/test/ui/kindck/kindck-copy.stderr b/src/test/ui/kindck/kindck-copy.stderr
@@ -91,10 +91,10 @@ LL | fn assert_copy<T:Copy>() { }
    |                  ^^^^ required by this bound in `assert_copy`
 
 error[E0277]: the trait bound `Box<dyn Dummy>: Copy` is not satisfied
-  --> $DIR/kindck-copy.rs:42:5
+  --> $DIR/kindck-copy.rs:42:19
    |
 LL |     assert_copy::<Box<dyn Dummy>>();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy>`
+   |                   ^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy>`
    |
 note: required by a bound in `assert_copy`
   --> $DIR/kindck-copy.rs:5:18
@@ -103,10 +103,10 @@ LL | fn assert_copy<T:Copy>() { }
    |                  ^^^^ required by this bound in `assert_copy`
 
 error[E0277]: the trait bound `Box<dyn Dummy + Send>: Copy` is not satisfied
-  --> $DIR/kindck-copy.rs:43:5
+  --> $DIR/kindck-copy.rs:43:19
    |
 LL |     assert_copy::<Box<dyn Dummy + Send>>();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy + Send>`
+   |                   ^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy + Send>`
    |
 note: required by a bound in `assert_copy`
   --> $DIR/kindck-copy.rs:5:18
diff --git a/src/test/ui/not-panic/not-panic-safe.stderr b/src/test/ui/not-panic/not-panic-safe.stderr
@@ -1,8 +1,11 @@
 error[E0277]: the type `&mut i32` may not be safely transferred across an unwind boundary
-  --> $DIR/not-panic-safe.rs:8:5
+  --> $DIR/not-panic-safe.rs:8:14
    |
 LL |     assert::<&mut i32>();
-   |     ^^^^^^^^^^^^^^^^^^ `&mut i32` may not be safely transferred across an unwind boundary
+   |              -^^^^^^^
+   |              |
+   |              `&mut i32` may not be safely transferred across an unwind boundary
+   |              help: consider removing the leading `&`-reference
    |
    = help: the trait `UnwindSafe` is not implemented for `&mut i32`
    = note: `UnwindSafe` is implemented for `&i32`, but not for `&mut i32`
diff --git a/src/test/ui/traits/issue-32963.rs b/src/test/ui/traits/issue-32963.rs
@@ -7,6 +7,5 @@ fn size_of_copy<T: Copy+?Sized>() -> usize { mem::size_of::<T>() }
 fn main() {
     size_of_copy::<dyn Misc + Copy>();
     //~^ ERROR only auto traits can be used as additional traits in a trait object
-    //~| ERROR only auto traits can be used as additional traits in a trait object
     //~| ERROR the trait bound `dyn Misc: Copy` is not satisfied
 }
diff --git a/src/test/ui/traits/issue-32963.stderr b/src/test/ui/traits/issue-32963.stderr
@@ -9,30 +9,19 @@ LL |     size_of_copy::<dyn Misc + Copy>();
    = help: consider creating a new trait with all of these as supertraits and using that trait here instead: `trait NewTrait: Misc + Copy {}`
    = note: auto-traits like `Send` and `Sync` are traits that have special properties; for more information on them, visit <https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits>
 
-error[E0225]: only auto traits can be used as additional traits in a trait object
-  --> $DIR/issue-32963.rs:8:31
-   |
-LL |     size_of_copy::<dyn Misc + Copy>();
-   |                        ----   ^^^^ additional non-auto trait
-   |                        |
-   |                        first non-auto trait
-   |
-   = help: consider creating a new trait with all of these as supertraits and using that trait here instead: `trait NewTrait: Misc + Copy {}`
-   = note: auto-traits like `Send` and `Sync` are traits that have special properties; for more information on them, visit <https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits>
-
 error[E0277]: the trait bound `dyn Misc: Copy` is not satisfied
-  --> $DIR/issue-32963.rs:8:5
+  --> $DIR/issue-32963.rs:8:20
    |
 LL |     size_of_copy::<dyn Misc + Copy>();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `dyn Misc`
+   |                    ^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `dyn Misc`
    |
 note: required by a bound in `size_of_copy`
   --> $DIR/issue-32963.rs:5:20
    |
 LL | fn size_of_copy<T: Copy+?Sized>() -> usize { mem::size_of::<T>() }
    |                    ^^^^ required by this bound in `size_of_copy`
 
-error: aborting due to 3 previous errors
+error: aborting due to 2 previous errors
 
 Some errors have detailed explanations: E0225, E0277.
 For more information about an error, try `rustc --explain E0225`.
diff --git a/src/test/ui/traits/suggest-where-clause.stderr b/src/test/ui/traits/suggest-where-clause.stderr
@@ -85,10 +85,10 @@ LL | pub const fn size_of<T>() -> usize {
    |                      ^ required by this bound in `std::mem::size_of`
 
 error[E0277]: the size for values of type `[&U]` cannot be known at compilation time
-  --> $DIR/suggest-where-clause.rs:31:5
+  --> $DIR/suggest-where-clause.rs:31:20
    |
 LL |     mem::size_of::<[&U]>();
-   |     ^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
+   |                    ^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `Sized` is not implemented for `[&U]`
 note: required by a bound in `std::mem::size_of`
diff --git a/src/test/ui/typeck/typeck-default-trait-impl-assoc-type.stderr b/src/test/ui/typeck/typeck-default-trait-impl-assoc-type.stderr
@@ -1,8 +1,8 @@
 error[E0277]: `<T as Trait>::AssocType` cannot be sent between threads safely
-  --> $DIR/typeck-default-trait-impl-assoc-type.rs:11:5
+  --> $DIR/typeck-default-trait-impl-assoc-type.rs:11:15
    |
 LL |     is_send::<T::AssocType>();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^ `<T as Trait>::AssocType` cannot be sent between threads safely
+   |               ^^^^^^^^^^^^ `<T as Trait>::AssocType` cannot be sent between threads safely
    |
    = help: the trait `Send` is not implemented for `<T as Trait>::AssocType`
 note: required by a bound in `is_send`
diff --git a/src/test/ui/unboxed-closures/unboxed-closure-sugar-default.stderr b/src/test/ui/unboxed-closures/unboxed-closure-sugar-default.stderr
@@ -1,8 +1,8 @@
 error[E0277]: the trait bound `dyn Foo<(isize,), isize, Output = ()>: Eq<dyn Foo<(isize,), Output = ()>>` is not satisfied
-  --> $DIR/unboxed-closure-sugar-default.rs:21:5
+  --> $DIR/unboxed-closure-sugar-default.rs:21:10
    |
 LL |     eq::<dyn Foo<(isize,), isize, Output=()>, dyn Foo(isize)>();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(isize,), Output = ()>>` is not implemented for `dyn Foo<(isize,), isize, Output = ()>`
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(isize,), Output = ()>>` is not implemented for `dyn Foo<(isize,), isize, Output = ()>`
    |
 note: required by a bound in `eq`
   --> $DIR/unboxed-closure-sugar-default.rs:14:40
diff --git a/src/test/ui/unboxed-closures/unboxed-closure-sugar-equiv.rs b/src/test/ui/unboxed-closures/unboxed-closure-sugar-equiv.rs
@@ -42,7 +42,7 @@ fn test<'a,'b>() {
     // Errors expected:
     eq::< dyn Foo<(),Output=()>,
           dyn Foo(char)                                               >();
-    //~^^ ERROR E0277
+    //~^ ERROR E0277
 }
 
 fn main() { }
diff --git a/src/test/ui/unboxed-closures/unboxed-closure-sugar-equiv.stderr b/src/test/ui/unboxed-closures/unboxed-closure-sugar-equiv.stderr
@@ -1,9 +1,8 @@
 error[E0277]: the trait bound `dyn Foo<(char,), Output = ()>: Eq<dyn Foo<(), Output = ()>>` is not satisfied
-  --> $DIR/unboxed-closure-sugar-equiv.rs:43:5
+  --> $DIR/unboxed-closure-sugar-equiv.rs:44:11
    |
-LL | /     eq::< dyn Foo<(),Output=()>,
-LL | |           dyn Foo(char)                                               >();
-   | |_______________________________________________________________________^ the trait `Eq<dyn Foo<(), Output = ()>>` is not implemented for `dyn Foo<(char,), Output = ()>`
+LL |           dyn Foo(char)                                               >();
+   |           ^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(), Output = ()>>` is not implemented for `dyn Foo<(char,), Output = ()>`
    |
 note: required by a bound in `eq`
   --> $DIR/unboxed-closure-sugar-equiv.rs:16:28

Original file line number	Diff line number	Diff line change
`@@ -91,10 +91,10 @@ LL \| fn assert_copy<T:Copy>() { }`
`91`	`91`	\| ^^^^ required by this bound in `assert_copy`
`92`	`92`
`93`	`93`	error[E0277]: the trait bound `Box<dyn Dummy>: Copy` is not satisfied
`94`		`- --> $DIR/kindck-copy.rs:42:5`
	`94`	`+ --> $DIR/kindck-copy.rs:42:19`
`95`	`95`	`\|`
`96`	`96`	`LL \| assert_copy::<Box<dyn Dummy>>();`
`97`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy>`
	`97`	+ \| ^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy>`
`98`	`98`	`\|`
`99`	`99`	note: required by a bound in `assert_copy`
`100`	`100`	`--> $DIR/kindck-copy.rs:5:18`
`@@ -103,10 +103,10 @@ LL \| fn assert_copy<T:Copy>() { }`
`103`	`103`	\| ^^^^ required by this bound in `assert_copy`
`104`	`104`
`105`	`105`	error[E0277]: the trait bound `Box<dyn Dummy + Send>: Copy` is not satisfied
`106`		`- --> $DIR/kindck-copy.rs:43:5`
	`106`	`+ --> $DIR/kindck-copy.rs:43:19`
`107`	`107`	`\|`
`108`	`108`	`LL \| assert_copy::<Box<dyn Dummy + Send>>();`
`109`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy + Send>`
	`109`	+ \| ^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `Box<dyn Dummy + Send>`
`110`	`110`	`\|`
`111`	`111`	note: required by a bound in `assert_copy`
`112`	`112`	`--> $DIR/kindck-copy.rs:5:18`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,11 @@`
`1`	`1`	error[E0277]: the type `&mut i32` may not be safely transferred across an unwind boundary
`2`		`- --> $DIR/not-panic-safe.rs:8:5`
	`2`	`+ --> $DIR/not-panic-safe.rs:8:14`
`3`	`3`	`\|`
`4`	`4`	`LL \| assert::<&mut i32>();`
`5`		- \| ^^^^^^^^^^^^^^^^^^ `&mut i32` may not be safely transferred across an unwind boundary
	`5`	`+ \| -^^^^^^^`
	`6`	`+ \| \|`
	`7`	+ \| `&mut i32` may not be safely transferred across an unwind boundary
	`8`	+ \| help: consider removing the leading `&`-reference
`6`	`9`	`\|`
`7`	`10`	= help: the trait `UnwindSafe` is not implemented for `&mut i32`
`8`	`11`	= note: `UnwindSafe` is implemented for `&i32`, but not for `&mut i32`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,5 @@ fn size_of_copy<T: Copy+?Sized>() -> usize { mem::size_of::<T>() }`
`7`	`7`	`fn main() {`
`8`	`8`	`size_of_copy::<dyn Misc + Copy>();`
`9`	`9`	`//~^ ERROR only auto traits can be used as additional traits in a trait object`
`10`		`- //~\| ERROR only auto traits can be used as additional traits in a trait object`
`11`	`10`	//~\| ERROR the trait bound `dyn Misc: Copy` is not satisfied
`12`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ LL \| pub const fn size_of<T>() -> usize {`
`85`	`85`	\| ^ required by this bound in `std::mem::size_of`
`86`	`86`
`87`	`87`	error[E0277]: the size for values of type `[&U]` cannot be known at compilation time
`88`		`- --> $DIR/suggest-where-clause.rs:31:5`
	`88`	`+ --> $DIR/suggest-where-clause.rs:31:20`
`89`	`89`	`\|`
`90`	`90`	`LL \| mem::size_of::<[&U]>();`
`91`		`- \| ^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time`
	`91`	`+ \| ^^^^ doesn't have a size known at compile-time`
`92`	`92`	`\|`
`93`	`93`	= help: the trait `Sized` is not implemented for `[&U]`
`94`	`94`	note: required by a bound in `std::mem::size_of`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	error[E0277]: `<T as Trait>::AssocType` cannot be sent between threads safely
`2`		`- --> $DIR/typeck-default-trait-impl-assoc-type.rs:11:5`
	`2`	`+ --> $DIR/typeck-default-trait-impl-assoc-type.rs:11:15`
`3`	`3`	`\|`
`4`	`4`	`LL \| is_send::<T::AssocType>();`
`5`		- \| ^^^^^^^^^^^^^^^^^^^^^^^ `<T as Trait>::AssocType` cannot be sent between threads safely
	`5`	+ \| ^^^^^^^^^^^^ `<T as Trait>::AssocType` cannot be sent between threads safely
`6`	`6`	`\|`
`7`	`7`	= help: the trait `Send` is not implemented for `<T as Trait>::AssocType`
`8`	`8`	note: required by a bound in `is_send`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	error[E0277]: the trait bound `dyn Foo<(isize,), isize, Output = ()>: Eq<dyn Foo<(isize,), Output = ()>>` is not satisfied
`2`		`- --> $DIR/unboxed-closure-sugar-default.rs:21:5`
	`2`	`+ --> $DIR/unboxed-closure-sugar-default.rs:21:10`
`3`	`3`	`\|`
`4`	`4`	`LL \| eq::<dyn Foo<(isize,), isize, Output=()>, dyn Foo(isize)>();`
`5`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(isize,), Output = ()>>` is not implemented for `dyn Foo<(isize,), isize, Output = ()>`
	`5`	+ \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(isize,), Output = ()>>` is not implemented for `dyn Foo<(isize,), isize, Output = ()>`
`6`	`6`	`\|`
`7`	`7`	note: required by a bound in `eq`
`8`	`8`	`--> $DIR/unboxed-closure-sugar-default.rs:14:40`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ fn test<'a,'b>() {`
`42`	`42`	`// Errors expected:`
`43`	`43`	`eq::< dyn Foo<(),Output=()>,`
`44`	`44`	`dyn Foo(char) >();`
`45`		`- //~^^ ERROR E0277`
	`45`	`+ //~^ ERROR E0277`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`fn main() { }`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,8 @@`
`1`	`1`	error[E0277]: the trait bound `dyn Foo<(char,), Output = ()>: Eq<dyn Foo<(), Output = ()>>` is not satisfied
`2`		`- --> $DIR/unboxed-closure-sugar-equiv.rs:43:5`
	`2`	`+ --> $DIR/unboxed-closure-sugar-equiv.rs:44:11`
`3`	`3`	`\|`
`4`		`-LL \| / eq::< dyn Foo<(),Output=()>,`
`5`		`-LL \| \| dyn Foo(char) >();`
`6`		- \| \|_______________________________________________________________________^ the trait `Eq<dyn Foo<(), Output = ()>>` is not implemented for `dyn Foo<(char,), Output = ()>`
	`4`	`+LL \| dyn Foo(char) >();`
	`5`	+ \| ^^^^^^^^^^^^^ the trait `Eq<dyn Foo<(), Output = ()>>` is not implemented for `dyn Foo<(char,), Output = ()>`
`7`	`6`	`\|`
`8`	`7`	note: required by a bound in `eq`
`9`	`8`	`--> $DIR/unboxed-closure-sugar-equiv.rs:16:28`