Skip to content

Commit f93032c

Browse files
committed
Fix clippy::clone_on_copy warnings
1 parent 21d5b8b commit f93032c

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

src/liballoc/collections/linked_list.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -237,15 +237,15 @@ impl<T> LinkedList<T> {
237237

238238
// Not creating new mutable (unique!) references overlapping `element`.
239239
match node.prev {
240-
Some(prev) => (*prev.as_ptr()).next = node.next.clone(),
240+
Some(prev) => (*prev.as_ptr()).next = node.next,
241241
// this node is the head node
242-
None => self.head = node.next.clone(),
242+
None => self.head = node.next,
243243
};
244244

245245
match node.next {
246-
Some(next) => (*next.as_ptr()).prev = node.prev.clone(),
246+
Some(next) => (*next.as_ptr()).prev = node.prev,
247247
// this node is the tail node
248-
None => self.tail = node.prev.clone(),
248+
None => self.tail = node.prev,
249249
};
250250

251251
self.len -= 1;

src/liballoc/rc.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ impl<T> Rc<[T]> {
815815
let slice = from_raw_parts_mut(self.elems, self.n_elems);
816816
ptr::drop_in_place(slice);
817817

818-
Global.dealloc(self.mem, self.layout.clone());
818+
Global.dealloc(self.mem, self.layout);
819819
}
820820
}
821821
}

src/liballoc/sync.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ impl<T> Arc<[T]> {
703703
let slice = from_raw_parts_mut(self.elems, self.n_elems);
704704
ptr::drop_in_place(slice);
705705

706-
Global.dealloc(self.mem.cast(), self.layout.clone());
706+
Global.dealloc(self.mem.cast(), self.layout);
707707
}
708708
}
709709
}

src/libcore/alloc.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -827,11 +827,11 @@ pub unsafe trait Alloc {
827827
let old_size = layout.size();
828828

829829
if new_size >= old_size {
830-
if let Ok(()) = self.grow_in_place(ptr, layout.clone(), new_size) {
830+
if let Ok(()) = self.grow_in_place(ptr, layout, new_size) {
831831
return Ok(ptr);
832832
}
833833
} else if new_size < old_size {
834-
if let Ok(()) = self.shrink_in_place(ptr, layout.clone(), new_size) {
834+
if let Ok(()) = self.shrink_in_place(ptr, layout, new_size) {
835835
return Ok(ptr);
836836
}
837837
}

src/libstd/sys/unix/alloc.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ unsafe impl GlobalAlloc for System {
2929
if layout.align() <= MIN_ALIGN && layout.align() <= layout.size() {
3030
libc::calloc(layout.size(), 1) as *mut u8
3131
} else {
32-
let ptr = self.alloc(layout.clone());
32+
let ptr = self.alloc(layout);
3333
if !ptr.is_null() {
3434
ptr::write_bytes(ptr, 0, layout.size());
3535
}

0 commit comments

Comments
 (0)