run-make: fix run_make_support::fs::create_symlink
API and audit symlink usages in rmake.rs tests
#129389
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
I need to revisit
run_make_support::fs::create_symlink
because it's a wrong abstraction: there's a good reason whysymlink_file
/symlink_dir
are different operations understd::os::windows::fs
.Furthermore, I need to double-check our symlink handling in rmake.rs tests. It's ok if symlinks are removed via
fs::remove_dir_all
because that has special handling for symlinks on Windows, but need to be extra careful if symlinks are attempted to be removed withfs::{remove_file, remove_dir}
if the test can be run on Windows.The text was updated successfully, but these errors were encountered: