Skip to content

bootstrap: optimizations could tell what "true" means #140328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthiaskrgr opened this issue Apr 26, 2025 · 0 comments · Fixed by #140330
Closed

bootstrap: optimizations could tell what "true" means #140328

matthiaskrgr opened this issue Apr 26, 2025 · 0 comments · Fixed by #140330
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

# Whether or not to optimize when compiling the compiler and standard library,
# and what level of optimization to use.
# WARNING: Building with optimize = false is NOT SUPPORTED. Due to bootstrapping,
# building without optimizations takes much longer than optimizing. Further, some platforms
# fail to build without this optimization (c.f. #65352).
# The valid options are:
# true - Enable optimizations.
# false - Disable optimizations.
# 0 - Disable optimizations.
# 1 - Basic optimizations.
# 2 - Some optimizations.
# 3 - All optimizations.
# "s" - Optimize for binary size.
# "z" - Optimize for binary size, but also turn off loop vectorization.
#optimize = true

It's not clear what the default true corresponds to. Basic? Some? All?
I think its 3 but the config.toml should say that explicitly.

@matthiaskrgr matthiaskrgr added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 26, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 26, 2025
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 26, 2025
tgross35 added a commit to tgross35/rust that referenced this issue Apr 27, 2025
Clarified bootstrap optimization "true" argument

fixes rust-lang#140328
tgross35 added a commit to tgross35/rust that referenced this issue Apr 27, 2025
Clarified bootstrap optimization "true" argument

fixes rust-lang#140328
tgross35 added a commit to tgross35/rust that referenced this issue Apr 27, 2025
Clarified bootstrap optimization "true" argument

fixes rust-lang#140328
@bors bors closed this as completed in 2575c7d Apr 27, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 27, 2025
Rollup merge of rust-lang#140330 - Kivooeo:new-fix-five, r=clubby789

Clarified bootstrap optimization "true" argument

fixes rust-lang#140328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants