Skip to content

Tool support for testing wasm targets #38803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jan 3, 2017 · 2 comments
Closed

Tool support for testing wasm targets #38803

brson opened this issue Jan 3, 2017 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 3, 2017

In order to make the wasm targets production ready we'll need a testing solution. Right now I'm inclined to teach cross how to do it and call that the solution, but that excludes macOS hosts, and for now at least, Windows as well, since it relies on docker.

cc @japaric

@brson brson added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ C-enhancement Category: An issue proposing an enhancement or a PR with one. T-tools labels Jan 3, 2017
@japaric
Copy link
Member

japaric commented Jan 4, 2017

Right now I'm inclined to teach cross

See rust-lang/cross#36. If rustc emitted executable .js files with a #!/usr/bin/env node shebang in them then cross test would work for the asmjs target. I'm not sure what else would need to be done for the wasm target though because node hello-wasm.js errors with node v7.3.0 as stated in that PR.

@Mark-Simulacrum Mark-Simulacrum added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 24, 2017
@alexcrichton
Copy link
Member

I believe we've since implemented the "runner" configuration in Cargo, which I believe solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants