Skip to content

rustdoc: clicking line numbers on source view does nothing #85119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsha opened this issue May 9, 2021 · 1 comment · Fixed by #85148
Closed

rustdoc: clicking line numbers on source view does nothing #85119

jsha opened this issue May 9, 2021 · 1 comment · Fixed by #85148
Assignees
@GuillaumeGomez
Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented May 9, 2021

Steps to reproduce:

  1. Visit https://doc.rust-lang.org/src/std/io/mod.rs.html or https://doc.rust-lang.org/nightly/src/std/io/mod.rs.html
  2. Click a line number.

Expected result:

Line number is highlighted and URL fragment changes.

Actual result:

Nothing happens.

/cc @GuillaumeGomez
@jsha jsha added C-bug Category: This is a bug. A-rustdoc-js Area: Rustdoc's JS front-end T-rustdoc labels May 9, 2021
@GuillaumeGomez
Copy link
Member

I'll fix this tomorrow.

@GuillaumeGomez GuillaumeGomez self-assigned this May 9, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue May 10, 2021
Merged
@bors bors closed this as completed in 3962541 May 10, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix source code line number display and make it clickable again GuillaumeGomez/rust
3 participants
@jsha @GuillaumeGomez @jyn514