Add regression test for #105735 #113759
Closed
Add regression test for #105735 #113759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
notriddle
reviewed
Jul 16, 2023
| // @has 'foo/index.html' | ||
| // @has - '//*[@class="item-name"]/a[@class="struct"]' 'AtomicU8' | ||
| // @has - '//*[@class="item-name"]/a[@class="constant"]' 'AtomicU8' | ||
| // @has - '//*[@id="reexport.AtomicU8"]/code' 'pub use crate::thing::AtomicU8;' |
There was a problem hiding this comment.
Isn't this the result that we don't want?
|
Oh I see. I thought it was the expected results reexports should be inlined in this case indeed. Closing and will reopen with appropriate fix. |
|
The point is that reexports should either be inlined, or they should be shown, but not both. The test case says there are three items: the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105735.
The work on re-export is now mostly finished (some bugs might remain, but I think I went through most of them already). Adding more regression tests is a good idea though.
r? @notriddle