Skip to content

Unit test improvements #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jasoncouture opened this issue Jan 3, 2023 · 1 comment
Open

Unit test improvements #305

jasoncouture opened this issue Jan 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jasoncouture
Copy link
Contributor

jasoncouture commented Jan 3, 2023 •
edited
Loading

During development of #302 tftp boots broke.

This caused the tests to hang, and never display the tftp failure panic.

I propose the following changes:

  1. Add support for bootloader panic hander that uses the qemu exit port during tests.
  2. Write a macro that splits the tests into _bios, _uefi, and _tftp
@phil-opp
Copy link
Member

phil-opp commented Jan 3, 2023

Sounds reasonable to me!

@phil-opp phil-opp added the enhancement New feature or request label Jan 3, 2023
@jasoncouture jasoncouture mentioned this issue Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasoncouture @phil-opp