-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZENKO-865 - clarify setup for e2e CRR tests #230
ZENKO-865 - clarify setup for e2e CRR tests #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for maintaining this! 😸
tests/backbeat/Using.md
Outdated
should be set as the Zenko endpoint for testing: | ||
|
||
``` | ||
export CLOUDSERVER_ENDPOINT=<cluster-ip of zenko-cloudserver> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out loud here 💭. Maybe to follow the pattern of avoiding spaces we could use <zenko-cloudserver-cluster-ip>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated and squashed!
b2caada
to
9f99c55
Compare
tests/backbeat/Using.md
Outdated
``` | ||
kubectl get services | ||
``` | ||
Look for the service named `zenko-cloudserver`, the value under `CLUSTER-IP` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the cluster IP it would be preferable to simply use the value under NAME
which resolves in the DNS to the CLUSTER-IP
but at least with the NAME
we'll always resolve to the correct location (in case the IP ever changes).
tests/backbeat/Using.md
Outdated
@@ -9,18 +9,29 @@ | |||
127.0.0.1 zenko.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not your fault but would also help minimize confusion is if this changed to something like<insert-kube-node-ip-here>
zenko.local. This way it's more universal. Otherwise this and line 5 are assuming that:
- that you are ssh-ed to one of the kube servers and doing testing from there
or - doing a port-forward from a remote kube cluster to your laptop
But doesn't make sense for the many people that use kubectl
locally on a laptop to connect to the remote servers or running on something like minikube
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
5cb6f72
to
7885cd3
Compare
No description provided.