Skip to content
This repository was archived by the owner on Nov 7, 2022. It is now read-only.

Talking stops the game #234

Closed
scemino opened this issue Feb 4, 2021 · 1 comment
Closed

Talking stops the game #234

scemino opened this issue Feb 4, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@scemino
Copy link
Owner

scemino commented Feb 4, 2021

Describe the bug
When you talk to someone if there is no lip file, the game stops.

To Reproduce
Steps to reproduce the behavior:

  1. Use Ransome the first time
  2. Click on the hint flyer
  3. Ransome should say It says, "Need help playing Thimbleweed Park?"

Expected behavior
The engine is expecting a lip file corresponding to the text, but sometimes there is no lip file associated, in this example it's normal because we don't see Ransome.
The game should ignore and not crash 😉

Desktop (please complete the following information):

  • OS: macOS
  • Version: BigSur 11.1
@scemino scemino added the bug Something isn't working label Feb 4, 2021
@scemino scemino added this to the v0.7.1 milestone Feb 4, 2021
@scemino scemino self-assigned this Feb 4, 2021
@scemino scemino closed this as completed in 32fb22c Feb 4, 2021
@scemino scemino changed the title Talking can stop the game Talking stops the game Feb 4, 2021
@Mac1512
Copy link

Mac1512 commented Feb 6, 2021

I have compiled the commit: (17c5081)

In debug mode, it still crashes when Boris speaks, I think there is still a problem in some "Lip" file.

It has thrown me an exception:

debug_fail_river

debug_fail_river 2

In Release mode, I have not tried, but I have tried the version 0.7.1 Beta that you have released and being in release mode, in that part it does not fail. So, just throw the exception in Debug mode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants