Skip to content

Gaussian mixture params/training sample size #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinykuo opened this issue Nov 14, 2019 · 2 comments
Open

Gaussian mixture params/training sample size #7

kevinykuo opened this issue Nov 14, 2019 · 2 comments
Labels
feature request Request for a new feature

Comments

@kevinykuo
Copy link
Contributor

kevinykuo commented Nov 14, 2019

Any tips on optimizing performance/training time for the Bayesian Gaussian mixture training phase? Could we consider exposing the parameters and perhaps include sampling the training set? This piece doesn't seem to scale well to bigger datasets.

@csala
Copy link
Contributor

csala commented Dec 19, 2019

@kevinykuo I totally agree on exposing as many hyperparameters as possible, but I have some doubts about the subsampling, since this is something that could be easily done by the user outside of CTGAN.

Would you mind editing the issue title and description to make this one focus only on the GM Hyperparams, so we can start working on it right away, and opening another one to discuss the subsampling separately?
I can also do the edits myself, if you prefer. Let me know!

@kevinykuo
Copy link
Contributor Author

Currently the user doesn't have control over subsampling for VGM training, since it's hardcoded in https://github.com/DAI-Lab/CTGAN/blob/fd507166f132381bc62b60f6457028f5bcaa904c/ctgan/synthesizer.py#L114-L115

To clarify, the non-scalable piece is the BayesianGaussianMixture, so I'm proposing to subsample the data there for training data transformation, but when we train the actual GAN we still use the full training data.

These hyperparameters seem related enough to be tracked together, but feel free to organize as you see fit!

@csala csala added discussion needed internal The issue doesn't change the API or functionality labels Jun 22, 2020
@csala csala added feature request Request for a new feature and removed internal The issue doesn't change the API or functionality labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants