Merge pull request #1764 from serde-rs/collect

dtolnay · web-flow · commit 2a9971a69d60 · 2020-03-27T23:10:06.000-07:00
Simplify default Serializer::collect_str implementation
diff --git a/serde/src/ser/mod.rs b/serde/src/ser/mod.rs
@@ -1359,10 +1359,7 @@ pub trait Serializer: Sized {
     where
         T: Display,
     {
-        use lib::fmt::Write;
-        let mut string = String::new();
-        write!(string, "{}", value).unwrap();
-        self.serialize_str(&string)
+        self.serialize_str(&value.to_string())
     }
 
     /// Serialize a string produced by an implementation of `Display`.

Original file line number	Diff line number	Diff line change
`@@ -1359,10 +1359,7 @@ pub trait Serializer: Sized {`
`1359`	`1359`	`where`
`1360`	`1360`	`T: Display,`
`1361`	`1361`	`{`
`1362`		`- use lib::fmt::Write;`
`1363`		`- let mut string = String::new();`
`1364`		`- write!(string, "{}", value).unwrap();`
`1365`		`- self.serialize_str(&string)`
	`1362`	`+ self.serialize_str(&value.to_string())`
`1366`	`1363`	`}`
`1367`	`1364`
`1368`	`1365`	/// Serialize a string produced by an implementation of `Display`.