Skip to content

Improve function parameter resolution #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nblumhardt opened this issue Jun 2, 2021 · 1 comment
Closed

Improve function parameter resolution #42

nblumhardt opened this issue Jun 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@nblumhardt
Copy link
Member

User-defined functions can currently accept IFormatProvider and StringComparison parameters, along with the LogEventPropertyValues supplied via the expression.

The resolution logic is very basic, and only works if the "special" parameters are in the first position.

It would be great if LogEvent parameters can also be bound, and also, if NameResolver could supply additional (constant) values to bind to other arguments. Adding these things would provide a great opportunity to generalize how the expression compiler binds function parameters.
@nblumhardt nblumhardt added the enhancement New feature or request label Jun 2, 2021
@nblumhardt
Copy link
Member Author

Released in 3.1.0; see #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nblumhardt