Skip to content

Ensure that warn! output is visible in client outputs. #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glennw opened this issue Sep 7, 2017 · 8 comments
Closed

Ensure that warn! output is visible in client outputs. #1677

glennw opened this issue Sep 7, 2017 · 8 comments

Comments

@glennw
Copy link
Member

glennw commented Sep 7, 2017

No description provided.

@kvark
Copy link
Member

kvark commented Sep 8, 2017

I don't think it's necessarily a responsibility of WR. log crate defines standard ways to process the output, and one casual example of the consumer is env_logger. Servo hooks up to the log stream as well.

@glennw
Copy link
Member Author

glennw commented Sep 8, 2017

There's an existing bug (from @nical I think) about providing an interface for C++ clients to access a logging stream (perhaps via callback). This is probably related to that.

@nical
Copy link
Contributor

nical commented Sep 8, 2017

In gecko we have various ways to log warnings. The one that I am interested in having some plumbing for in webrender is the gfxCriticalError/gfxCriticalNote that saves the log in the crash reports. We tend to use it sparingly, only in places where we are likely to crash soon and the logged information would helps with investigating the issue. It is super useful.

@kvark
Copy link
Member

kvark commented Sep 8, 2017

@nical sounds good. Could you create a Bugzilla item for this?

@nical
Copy link
Contributor

nical commented Sep 13, 2017

@staktrace
Copy link
Contributor

@JerryShih
Copy link
Contributor

I have some updates for this in https://bugzilla.mozilla.org/show_bug.cgi?id=1399389.

@gw3583
Copy link
Contributor

gw3583 commented Feb 1, 2019

The associated bugzilla bugs are fixed.

@gw3583 gw3583 closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants