Skip to content

Commit 2892b9b

Browse files
authoredMar 15, 2025
bugfix: Update sampling_params.py (#4413)
1 parent 470b474 commit 2892b9b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed
 

‎python/sglang/srt/sampling/sampling_params.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __init__(
7777
self.custom_params = custom_params
7878

7979
# Process some special cases
80-
if self.temperature < _SAMPLING_EPS:
80+
if 0 <= self.temperature < _SAMPLING_EPS:
8181
# top_k = 1 means greedy sampling
8282
self.temperature = 1.0
8383
self.top_k = 1
@@ -93,9 +93,9 @@ def verify(self):
9393
raise ValueError(f"top_p must be in (0, 1], got {self.top_p}.")
9494
if not 0.0 <= self.min_p <= 1.0:
9595
raise ValueError(f"min_p must be in [0, 1], got {self.min_p}.")
96-
if self.top_k < -1 or self.top_k == 0:
96+
if self.top_k < 1 or self.top_k == -1:
9797
raise ValueError(
98-
f"top_k must be -1 (disable), or at least 1, " f"got {self.top_k}."
98+
f"top_k must be -1 (disable) or at least 1, got {self.top_k}."
9999
)
100100
if not -2.0 <= self.frequency_penalty <= 2.0:
101101
raise ValueError(
@@ -108,12 +108,12 @@ def verify(self):
108108
)
109109
if not 0.0 <= self.repetition_penalty <= 2.0:
110110
raise ValueError(
111-
"repetition_penalty must be in (0, 2], got "
111+
"repetition_penalty must be in [0, 2], got "
112112
f"{self.repetition_penalty}."
113113
)
114114
if not 0 <= self.min_new_tokens:
115115
raise ValueError(
116-
f"min_new_tokens must be in (0, max_new_tokens], got "
116+
f"min_new_tokens must be in [0, max_new_tokens], got "
117117
f"{self.min_new_tokens}."
118118
)
119119
if self.max_new_tokens is not None:
@@ -123,7 +123,7 @@ def verify(self):
123123
)
124124
if not self.min_new_tokens <= self.max_new_tokens:
125125
raise ValueError(
126-
f"min_new_tokens must be in (0, max_new_tokens({self.max_new_tokens})], got "
126+
f"min_new_tokens must be in [0, max_new_tokens({self.max_new_tokens})], got "
127127
f"{self.min_new_tokens}."
128128
)
129129
grammars = [

0 commit comments

Comments
 (0)