Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParsedBody #4

Closed
akrabat opened this issue Jan 17, 2017 · 2 comments
Closed

ParsedBody #4

akrabat opened this issue Jan 17, 2017 · 2 comments

Comments

@akrabat
Copy link
Member

akrabat commented Jan 17, 2017

I'm removing non-PSR-7 methods from Slim-Psr7

However, when it comes to the parsed body of the Request object, Should Slim-Psr7 continue to handle it's own decoding of body using the media types or should this functionality be moved elsewhere?

@geggleto
Copy link
Member

The functionality should not change.
However we should be making it easy to add in our own decoders.

How we do that... I have no idea, but probably in some sort of Middleware.

@mathmarques
Copy link

Shouldn't we move this to Middleware?
On ExpressJS we use middlewares(see the middleware here) and works well.

Another thing with ParsedBody:
Setting $bodyParsed to false was a fix for an issue. Maybe if we change the way parsedBody() works, we could remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants