From 9f16664895733dc77f71394b467638b9251049c8 Mon Sep 17 00:00:00 2001 From: Varun Gandhi Date: Sat, 30 Nov 2024 16:29:56 +0800 Subject: [PATCH] chore: Use faster 3 way string comparison --- bindings/go/scip/sort.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/bindings/go/scip/sort.go b/bindings/go/scip/sort.go index 3e76ad2b..b18559cd 100644 --- a/bindings/go/scip/sort.go +++ b/bindings/go/scip/sort.go @@ -2,6 +2,7 @@ package scip import ( "sort" + "strings" "golang.org/x/exp/slices" ) @@ -24,12 +25,7 @@ func FindSymbol(document *Document, symbolName string) *SymbolInformation { // and SymbolInformation values must be merged. This guarantee is upheld by CanonicalizeDocument. func FindSymbolBinarySearch(canonicalizedDocument *Document, symbolName string) *SymbolInformation { i, found := slices.BinarySearchFunc(canonicalizedDocument.Symbols, symbolName, func(sym *SymbolInformation, lookup string) int { - if sym.Symbol < lookup { - return -1 - } else if sym.Symbol == lookup { - return 0 - } - return 1 + return strings.Compare(sym.Symbol, lookup) }) if found { return canonicalizedDocument.Symbols[i]