Skip to content

Saml2WebSsoAuthenticationFilter should allow requests through when SAMLResponse is absent #16000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Oct 25, 2024 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Oct 25, 2024

When an application requests /login/saml2/sso/okta, the default entry point for IdPs to POST a SAMLResponse, the endpoint will throw an exception if the SAMLResponse is missing.

It would be more flexible to instead allow these requests to pass through the filter chain in case another filter or MVC mapping would like to process the endpoint. One reason for this would be if the payload deviates from the SAML 2.0 standard.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Oct 25, 2024
@jzheaux jzheaux added this to the 6.5.x milestone Oct 25, 2024
@jzheaux jzheaux closed this as completed in 67c21de Apr 3, 2025
@jzheaux jzheaux modified the milestones: 6.5.x, 6.5.0-RC1 Apr 3, 2025
@jzheaux jzheaux self-assigned this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant