Skip to content

defaultBlockTag type can accept null #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dongliang1993 opened this issue Sep 30, 2019 · 1 comment
Open

defaultBlockTag type can accept null #197

dongliang1993 opened this issue Sep 30, 2019 · 1 comment

Comments

@dongliang1993
Copy link

defaultBlockTag can accept null in doc, but types maybe wrong

now:

draft-js-utils/packages/draft-js-export-html/typings/index.d.ts

Line 16 in 4007f3e

defaultBlockTag?: string;

should be:
defaultBlockTag?: string | null;
@pereznieto pereznieto mentioned this issue Nov 14, 2019
Open
@pereznieto
Copy link

My team was also being affected by this issue, so I've raised a PR to add the suggested change: #201

@voidpumpkin voidpumpkin mentioned this issue Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dongliang1993 @pereznieto