Allow async defaultChildNode (SAP#253)

 defaultChildNode did not work if children are loaded via function or promise

Author: maxmarkus

core/src/services/routing.js

@@ -9,6 +9,7 @@ import {
   getConfigValueFromObject,
   addLeadingSlash
 } from '../utilities/helpers';
+import { getConfigValueFromObjectAsync } from '../utilities/async-helpers';
 
 const iframeNavFallbackTimeout = 2000;
 let timeoutHandle;
@@ -19,18 +20,19 @@ const getLastNodeObject = pathData => {
   return lastElement ? lastElement : {};
 };
 
-const getDefaultChildNode = function(pathData) {
+const getDefaultChildNode = async function(pathData) {
   const lastElement =
     pathData.navigationPath[pathData.navigationPath.length - 1];
 
-  const pathExists = lastElement.children.find(
+  const children = await getConfigValueFromObjectAsync(lastElement, 'children');
+  const pathExists = children.find(
     childNode => childNode.pathSegment === lastElement.defaultChildNode
   );
 
   if (lastElement.defaultChildNode && pathExists) {
     return lastElement.defaultChildNode;
-  } else if (lastElement.children && lastElement.children.length > 0) {
-    return lastElement.children[0].pathSegment;
+  } else if (children && children.length > 0) {
+    return children[0].pathSegment;
   } else {
     return '';
   }
@@ -322,7 +324,7 @@ export const handleRouteChange = async (path, component, node, config) => {
       const routeExists = isExistingRoute(path, pathData);
 
       if (routeExists) {
-        const defaultChildNode = getDefaultChildNode(pathData);
+        const defaultChildNode = await getDefaultChildNode(pathData);
         navigateTo(`${pathUrl ? `/${pathUrl}` : ''}/${defaultChildNode}`);
       } else {
         const alert = {

core/test/services/routing.spec.js

@@ -849,24 +849,52 @@ describe('Routing', () => {
       };
     };
 
-    it('should return first child if no defaultChildNode is set', () => {
+    it('should return first child if no defaultChildNode is set', async () => {
       let pathData = getPathData();
 
-      assert.equal(getDefaultChildNode(pathData), 'stakeholders');
+      assert.equal(await getDefaultChildNode(pathData), 'stakeholders');
     });
 
-    it('should return child with pathSegment equal to defaultChildNode', () => {
+    it('should return child with pathSegment equal to defaultChildNode', async () => {
       let pathData = getPathData();
       pathData.navigationPath[1].defaultChildNode = 'customers';
 
-      assert.equal(getDefaultChildNode(pathData), 'customers');
+      assert.equal(await getDefaultChildNode(pathData), 'customers');
     });
 
-    it('should return first child if given defaultChildNode does not exist', () => {
+    it('should return first child if given defaultChildNode does not exist', async () => {
       const pathData = getPathData();
       pathData.navigationPath[1].defaultChildNode = 'NOSUCHPATH';
 
-      assert.equal(getDefaultChildNode(pathData), 'stakeholders');
+      assert.equal(await getDefaultChildNode(pathData), 'stakeholders');
+    });
+
+    it('should return first child asynchronous if no defaultChildNode is set', async () => {
+      let pathData = {
+        navigationPath: [
+          {
+            // DOESN'T MATTER
+          },
+          {
+            pathSegment: 'groups',
+            children: () =>
+              Promise.resolve([
+                {
+                  pathSegment: 'stakeholders',
+                  viewUrl:
+                    '/sampleapp.html#/projects/1/users/groups/stakeholders'
+                },
+                {
+                  pathSegment: 'customers',
+                  viewUrl: '/sampleapp.html#/projects/1/users/groups/customers'
+                }
+              ])
+          }
+        ],
+        context: {}
+      };
+
+      assert.equal(await getDefaultChildNode(pathData), 'stakeholders');
     });
   });
 });