Skip to content

Default X-Client-Info header #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awalias opened this issue Aug 23, 2021 · 1 comment
Closed

Default X-Client-Info header #9

awalias opened this issue Aug 23, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@awalias
Copy link
Member

awalias commented Aug 23, 2021

we're rolling out a header similar to Stripe's App-Data in all of the client libs so issues can be debugged more easily between the client and the backend

the javascript libs are done already: supabase/supabase-js#238

the format is: X-Client-Info: supabase-js/1.11.0

for client libs that wrap others (like how supabase-js wraps gotrue-js) we allow the wrapper lib to overwrite the wrapped lib's header (given that we can infer the gotrue-js version based on which supabase-js was used to make the call)

any help with rolling this out here would be incredible

@awalias awalias added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 23, 2021
@lqmanh lqmanh added the enhancement New feature or request label Aug 23, 2021
@lqmanh
Copy link
Collaborator

lqmanh commented Aug 24, 2021

With the latest commit, Postgrest-py now allows setting custom headers in PostgrestClient's constructor. The rest should be handled by Supabase-py. I'll open a PR in a few days if I have free time.

@lqmanh lqmanh closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants