Skip to content

Consider combining myaddon and --myaddon #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rich-Harris opened this issue Apr 8, 2025 · 0 comments
Open

Consider combining myaddon and --myaddon #528

Rich-Harris opened this issue Apr 8, 2025 · 0 comments
Labels
enhancement New feature or request pkg:add sv add pkg:create

Comments

@Rich-Harris
Copy link
Member

At the moment if you do npx sv add myaddon you're asked to specify the options for myaddon, but there's also npx sv add --myaddon which doesn't prompt for options; it just selects defaults for you.

This distinction feels a little confusing to me. What if the prompt appears whenever an add-on has options and there's no =? And if the user specifies = but required options are missing, bail. So:

# prompt for drizzle options
npx sv add drizzle

# install drizzle with postgresql and postgres.js
npx sv add drizzle=postgresql,postgres.js

# bail, because required `client` option is missing (`docker` is not required in this example)
npx sv add drizzle=postgresql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:add sv add pkg:create
Projects
None yet
Development

No branches or pull requests

2 participants