Skip to content

Commit fe791bd

Browse files
committed
WiX: simplify the runtime package definition
- Use durable GUID generation for auto-generation of the GUID. - Combine the platform definitions into a singular source to avoid drift. This avoids having to keep the variants in sync and provides an easier upgrade path. This is the first step towards enabling a non-admin experience for users.
1 parent af89b7b commit fe791bd

8 files changed

+146
-351
lines changed

platforms/Windows/devtools.wixproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<Import Project="WiXCodeSigning.targets" />
2020

2121
<PropertyGroup>
22-
<DefineConstants>ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);</DefineConstants>
22+
<DefineConstants>ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);</DefineConstants>
2323
<HarvestDirectoryAutogenerateGuids>false</HarvestDirectoryAutogenerateGuids>
2424
<HarvestDirectoryGenerateGuidsNow>true</HarvestDirectoryGenerateGuidsNow>
2525
<HarvestDirectoryNoLogo>true</HarvestDirectoryNoLogo>

platforms/Windows/runtime-amd64.wxs

Lines changed: 0 additions & 116 deletions
This file was deleted.

platforms/Windows/runtime-arm64.wxs

Lines changed: 0 additions & 116 deletions
This file was deleted.

platforms/Windows/runtime-x86.wxs

Lines changed: 0 additions & 115 deletions
This file was deleted.

0 commit comments

Comments
 (0)