From b6b3ad007389a3d0d8271334873c3425dfdbf4aa Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Wed, 22 Mar 2023 17:54:09 -0400 Subject: [PATCH 1/2] Migrate the Windows installer to WiX v4. --- platforms/Windows/devtools-amd64.wxs | 63 ++++---- platforms/Windows/devtools-arm64.wxs | 63 ++++---- platforms/Windows/devtools.wixproj | 24 +-- platforms/Windows/installer.wixproj | 19 +-- platforms/Windows/installer.wxs | 9 +- platforms/Windows/runtime-amd64.wxs | 69 ++++---- platforms/Windows/runtime-arm64.wxs | 66 ++++---- platforms/Windows/runtime-x86.wxs | 69 ++++---- platforms/Windows/runtime.wixproj | 20 +-- platforms/Windows/sdk-amd64.wxs | 190 +++++++++++------------ platforms/Windows/sdk-arm64.wxs | 189 +++++++++++----------- platforms/Windows/sdk-x86.wxs | 181 ++++++++++----------- platforms/Windows/sdk.wixproj | 36 ++--- platforms/Windows/swift-format-amd64.wxs | 49 +++--- platforms/Windows/swift-format-arm64.wxs | 49 +++--- platforms/Windows/swift-format.wixproj | 24 +-- platforms/Windows/toolchain-amd64.wxs | 148 +++++++++--------- platforms/Windows/toolchain-arm64.wxs | 147 +++++++++--------- platforms/Windows/toolchain.wixproj | 42 ++--- 19 files changed, 667 insertions(+), 790 deletions(-) diff --git a/platforms/Windows/devtools-amd64.wxs b/platforms/Windows/devtools-amd64.wxs index 4c27f7ba..77fe229a 100644 --- a/platforms/Windows/devtools-amd64.wxs +++ b/platforms/Windows/devtools-amd64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,22 +14,20 @@ - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + @@ -35,9 +38,7 @@ - - NOT INSTALLDIR - + @@ -222,15 +223,15 @@ - + - - INSTALL_DEBUGINFO + + @@ -240,13 +241,13 @@ - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/devtools-arm64.wxs b/platforms/Windows/devtools-arm64.wxs index 0bd1bb1d..ffa787f6 100644 --- a/platforms/Windows/devtools-arm64.wxs +++ b/platforms/Windows/devtools-arm64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,22 +14,20 @@ - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + @@ -35,9 +38,7 @@ - - NOT INSTALLDIR - + @@ -222,15 +223,15 @@ - + - - INSTALL_DEBUGINFO + + @@ -240,13 +241,13 @@ - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/devtools.wixproj b/platforms/Windows/devtools.wixproj index c9ff27fc..736cd2cf 100644 --- a/platforms/Windows/devtools.wixproj +++ b/platforms/Windows/devtools.wixproj @@ -1,10 +1,6 @@ - - + - devtools - Package - 0a266072-af7c-43f2-b192-dd86995c2e82 - 2.0 + false @@ -18,15 +14,8 @@ build\ build\obj\ - false - - - - - - @@ -41,13 +30,10 @@ - - $(WixExtDir)\WixUIExtension.dll - WixUIExtension - + - + - + \ No newline at end of file diff --git a/platforms/Windows/installer.wixproj b/platforms/Windows/installer.wixproj index a164d1bc..3956b226 100644 --- a/platforms/Windows/installer.wixproj +++ b/platforms/Windows/installer.wixproj @@ -1,10 +1,7 @@ - - + - installer + false Bundle - 8ae3ad4d-2df4-42b7-890e-decdd5cead0b - 2.0 @@ -21,15 +18,8 @@ build\ build\obj\ - false - - - - - - @@ -37,10 +27,7 @@ - - $(WixExtDir)\WixBalExtension.dll - WixBalExtension - + diff --git a/platforms/Windows/installer.wxs b/platforms/Windows/installer.wxs index f3ed1ef0..6dc646c2 100644 --- a/platforms/Windows/installer.wxs +++ b/platforms/Windows/installer.wxs @@ -1,9 +1,8 @@ - - + - - - + + + diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs index 110834a3..544d7392 100644 --- a/platforms/Windows/runtime-amd64.wxs +++ b/platforms/Windows/runtime-amd64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,21 +14,17 @@ - - - - - - - + + + + + - + - - NOT INSTALLDIR - + @@ -108,12 +109,6 @@ - - - - - - @@ -164,44 +159,42 @@ - - - - - - + + + + - + - - INSTALL_DEBUGINFO + + - + - - INSTALL_DEBUGINFO + + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs index 73b1a230..de5e8dad 100644 --- a/platforms/Windows/runtime-arm64.wxs +++ b/platforms/Windows/runtime-arm64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,21 +14,18 @@ - - - - - - - + + + + + + - - NOT INSTALLDIR - + @@ -42,12 +44,6 @@ - - - - - - @@ -164,44 +160,42 @@ - - - - - + + + - + - - INSTALL_DEBUGINFO + + - + - - INSTALL_DEBUGINFO + + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs index 2f01bf7f..52edaf5b 100644 --- a/platforms/Windows/runtime-x86.wxs +++ b/platforms/Windows/runtime-x86.wxs @@ -1,28 +1,30 @@ - - - - + + + + - - - - - - - + + + + + - - - NOT INSTALLDIR - + + @@ -41,12 +43,6 @@ - - - - - - @@ -163,44 +159,41 @@ - - - - - + + + - + - - INSTALL_DEBUGINFO + + - + - - INSTALL_DEBUGINFO + + - - 1 - 1 + + + - + - - + diff --git a/platforms/Windows/runtime.wixproj b/platforms/Windows/runtime.wixproj index f464d2d7..f2673ff1 100644 --- a/platforms/Windows/runtime.wixproj +++ b/platforms/Windows/runtime.wixproj @@ -1,10 +1,6 @@ - - + - runtime - Package - - 2.0 + false @@ -18,15 +14,8 @@ build\ build\obj\ - false - - - - - - @@ -49,10 +38,7 @@ - - $(WixExtDir)\WixUIExtension.dll - WixUIExtension - + diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index 1e9c2507..68f2740f 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,94 +14,92 @@ - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - + - - - - - - - + + + + + + + + + + + + - + + + + + - - + + - - - - - + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + - - + + @@ -106,10 +109,9 @@ + - - NOT INSTALLDIR - + @@ -484,15 +486,13 @@ - - - - - - + + + + - + @@ -521,20 +521,20 @@ - - INSTALL_DEBUGINFO + + - + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/sdk-arm64.wxs b/platforms/Windows/sdk-arm64.wxs index dbca7c1f..6f13c2a4 100644 --- a/platforms/Windows/sdk-arm64.wxs +++ b/platforms/Windows/sdk-arm64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,94 +14,92 @@ - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - + - - - - - - - + + + + + + + + + + + + - + + + + + - - + + - - - - - + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + - - + + @@ -107,9 +110,7 @@ - - NOT INSTALLDIR - + @@ -484,15 +485,13 @@ - - - - - - + + + + - + @@ -521,20 +520,20 @@ - - INSTALL_DEBUGINFO + + - + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/sdk-x86.wxs b/platforms/Windows/sdk-x86.wxs index 5c87dc33..1e044b52 100644 --- a/platforms/Windows/sdk-x86.wxs +++ b/platforms/Windows/sdk-x86.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -9,94 +14,92 @@ - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - + - - - - - - - + + + + + + + + + + + + - + + + + + - - + + - - - - - + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + - - + + @@ -106,10 +109,8 @@ - - - NOT INSTALLDIR - + + @@ -486,7 +487,7 @@ - + @@ -513,20 +514,20 @@ - - INSTALL_DEBUGINFO + + - + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/sdk.wixproj b/platforms/Windows/sdk.wixproj index 33433f3b..24297666 100644 --- a/platforms/Windows/sdk.wixproj +++ b/platforms/Windows/sdk.wixproj @@ -1,10 +1,6 @@ - - + - sdk - Package - 39170311-3634-4a14-9546-7e4825e7dcd8 - 2.0 + false @@ -18,15 +14,8 @@ build\ build\obj\ - false - - - - - - @@ -40,24 +29,17 @@ true - - - - SwiftShims - WindowsSDK_usr_lib_swift_shims - var.SwiftShimsPath - - - - - - $(WixExtDir)\WixUIExtension.dll - WixUIExtension - + + + + SwiftShims + WindowsSDK_usr_lib_swift_shims + var.SwiftShimsPath + diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index c986cb7a..7a188eda 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -10,18 +15,14 @@ - - - - - + + + - - NOT INSTALLDIR - + @@ -38,32 +39,30 @@ - - - - - + + + - + - - INSTALL_DEBUGINFO + + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/swift-format-arm64.wxs b/platforms/Windows/swift-format-arm64.wxs index 4ff1f9bd..a64de654 100644 --- a/platforms/Windows/swift-format-arm64.wxs +++ b/platforms/Windows/swift-format-arm64.wxs @@ -1,7 +1,12 @@ - - - - + + + @@ -10,18 +15,14 @@ - - - - - + + + - - NOT INSTALLDIR - + @@ -38,32 +39,30 @@ - - - - - + + + - + - - INSTALL_DEBUGINFO + + - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/swift-format.wixproj b/platforms/Windows/swift-format.wixproj index a626470b..cbc44733 100644 --- a/platforms/Windows/swift-format.wixproj +++ b/platforms/Windows/swift-format.wixproj @@ -1,10 +1,6 @@ - - + - swift-format - Package - 19d8e67a-655f-4ac2-a868-2ce653506192 - 2.0 + false @@ -18,17 +14,6 @@ build\ build\obj\ - false - - - - - - - - - - $(MSBuildExtensionsPath)\Microsoft\WiX\v3.x\Wix.targets @@ -38,10 +23,7 @@ - - $(WixExtDir)\WixUIExtension.dll - WixUIExtension - + diff --git a/platforms/Windows/toolchain-amd64.wxs b/platforms/Windows/toolchain-amd64.wxs index 3137ddcc..4b732407 100644 --- a/platforms/Windows/toolchain-amd64.wxs +++ b/platforms/Windows/toolchain-amd64.wxs @@ -1,7 +1,12 @@ - - - - + + + - - - - - - - - + + + + + + + + + + - - - - - - - - - - - - - - - - - + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - - - - - + - - - - + + + + + + + + + + + - - NOT INSTALLDIR - + @@ -756,14 +758,12 @@ - - - - - - + + + + - + @@ -785,8 +785,8 @@ - - INSTALL_DEBUGINFO + + @@ -804,13 +804,13 @@ - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/toolchain-arm64.wxs b/platforms/Windows/toolchain-arm64.wxs index 5127cc9c..b05101c1 100644 --- a/platforms/Windows/toolchain-arm64.wxs +++ b/platforms/Windows/toolchain-arm64.wxs @@ -1,7 +1,12 @@ - - - - + + + - - - - - - - - + + + + + + + + + + - - - - - - - - - - - - - - - - - + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + - - - - - + - - - - + + + + + + + + + + - - NOT INSTALLDIR - + @@ -756,14 +757,12 @@ - - - - - - + + + + - + @@ -785,8 +784,8 @@ - - INSTALL_DEBUGINFO + + @@ -804,13 +803,13 @@ - - 1 - 1 + + + - + - + diff --git a/platforms/Windows/toolchain.wixproj b/platforms/Windows/toolchain.wixproj index 0739c724..600b7d3e 100644 --- a/platforms/Windows/toolchain.wixproj +++ b/platforms/Windows/toolchain.wixproj @@ -1,10 +1,6 @@ - - + - toolchain - Package - 6ebfb883-fc92-4b73-81ae-ddeb2cec4df9 - 2.0 + false @@ -18,15 +14,8 @@ build\ build\obj\ - false - - - - - - @@ -40,30 +29,17 @@ true - - - - - ClangResources - _usr_lib_clang - var.TOOLCHAIN_ROOT_USR_LIB_CLANG - - - - - - $(WixExtDir)\WixUIExtension.dll - WixUIExtension - + + + + ClangResources + _usr_lib_clang + var.TOOLCHAIN_ROOT_USR_LIB_CLANG + From 82dbb26f31b93fb5880317207fc7225e332c600a Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Thu, 23 Mar 2023 09:12:13 -0400 Subject: [PATCH 2/2] Added comment back --- platforms/Windows/toolchain.wixproj | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/platforms/Windows/toolchain.wixproj b/platforms/Windows/toolchain.wixproj index 600b7d3e..a909b48d 100644 --- a/platforms/Windows/toolchain.wixproj +++ b/platforms/Windows/toolchain.wixproj @@ -35,6 +35,12 @@ + ClangResources _usr_lib_clang