Skip to content

use build-script for static linux sdk build #80429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xavgru12 opened this issue Apr 1, 2025 · 2 comments
Closed

use build-script for static linux sdk build #80429

xavgru12 opened this issue Apr 1, 2025 · 2 comments
Labels
build-script Area → utils: The build script feature A feature request or implementation Linux Platform: Linux

Comments

@xavgru12
Copy link

xavgru12 commented Apr 1, 2025

Motivation

As of now the static linux sdk is built with this build.sh:

https://github.com/swiftlang/swift-docker/blob/main/swift-ci/sdks/static-linux/scripts/build.sh

Why is this separate from the common build? Why is this inside a docker repo when it is unrelated to docker?

Proposed solution

The main goal of build-script is to give a unified and reproducible build experience for everyone.
Providing a build.sh like this is not in favor of this.

Solution:
Integrate the linux static sdk build into the build-script.

Alternatives considered

No response

Additional information

No response

@xavgru12 xavgru12 added feature A feature request or implementation triage needed This issue needs more specific labels labels Apr 1, 2025
@xavgru12
Copy link
Author

xavgru12 commented Apr 1, 2025

What do you think? @MaxDesiatov

@finagolfin finagolfin added Linux Platform: Linux build-script Area → utils: The build script and removed triage needed This issue needs more specific labels labels Apr 1, 2025
@al45tair
Copy link
Contributor

I don't think this is a good idea. @etcwilde and @edymtt are currently busy building an entirely new build system and I think integrating the static SDK build into build-script at this point would not make sense.

@al45tair al45tair closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-script Area → utils: The build script feature A feature request or implementation Linux Platform: Linux
Projects
None yet
Development

No branches or pull requests

3 participants