Skip to content

Commit 1a068f9

Browse files
KocalKocal
committed
[Meta] Drop format, lint, check-format and check-lint commands, replace them with check and ci commands
1 parent 4d298e8 commit 1a068f9

File tree

23 files changed

+46
-87
lines changed

23 files changed

+46
-87
lines changed

‎.github/workflows/test.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ jobs:
2828
restore-keys: |
2929
${{ runner.os }}-yarn-
3030
- run: yarn --immutable
31-
- run: yarn check-lint
32-
- run: yarn check-format
31+
- run: yarn ci
3332

3433
js-dist-current:
3534
name: Check for UnBuilt JS Dist Files

‎CONTRIBUTING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,14 @@ To help you with assets, you can run the following commands in a specific packag
8181
- `yarn run build`: build (compile) assets from the package,
8282
- `yarn run watch`: watch for modifications and rebuild assets from the package,
8383
- `yarn run test`: run the tests from the package,
84-
- `yarn run lint`: lint assets from the package,
85-
- `yarn run format`: format assets from the package.
84+
- `yarn run check`: run the formatter, linter, and sort imports, and fails if any modifications
85+
- `yarn run check --write`: run the formatter, linter, imports sorting, and write modifications
8686

8787
Thanks to [Yarn Workspaces](https://yarnpkg.com/features/workspaces), you can also run these commands from the root directory of the project:
8888
- `yarn run build`: build (compile) assets from **all** packages,
8989
- `yarn run test`: run the tests from **all** packages,
90-
- `yarn run lint`: lint assets from **all** packages,
91-
- `yarn run format`: format assets from **all** packages,
90+
- `yarn run check`: run the formatter, linter, and sort imports for **all** packages, and fails if any modifications
91+
- `yarn run check --write`: run the formatter, linter, imports sorting for **all** packages, and write modifications
9292

9393
## Useful Git commands
9494

‎package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
"scripts": {
99
"build": "yarn workspaces foreach -Apt run build",
1010
"test": "yarn workspaces foreach -Apt run test",
11-
"lint": "biome lint --write",
12-
"format": "biome format --write",
13-
"check-lint": "biome lint",
14-
"check-format": "biome format"
11+
"check": "biome check",
12+
"ci": "biome ci"
1513
},
1614
"devDependencies": {
1715
"@babel/core": "^7.25.2",

‎src/Autocomplete/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/Chartjs/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"build": "node ../../../bin/build_package.js .",
1111
"watch": "node ../../../bin/build_package.js . --watch",
1212
"test": "../../../bin/test_package.sh .",
13-
"lint": "biome lint --write",
14-
"format": "biome format --write",
15-
"check-lint": "biome lint",
16-
"check-format": "biome format"
13+
"check": "biome check",
14+
"ci": "biome ci"
1715
},
1816
"symfony": {
1917
"controllers": {

‎src/Cropperjs/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
"build": "node ../../../bin/build_package.js .",
1313
"watch": "node ../../../bin/build_package.js . --watch",
1414
"test": "../../../bin/test_package.sh .",
15-
"lint": "biome lint --write",
16-
"format": "biome format --write",
17-
"check-lint": "biome lint",
18-
"check-format": "biome format"
15+
"check": "biome check",
16+
"ci": "biome ci"
1917
},
2018
"symfony": {
2119
"controllers": {

‎src/Dropzone/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
"build": "node ../../../bin/build_package.js .",
1313
"watch": "node ../../../bin/build_package.js . --watch",
1414
"test": "../../../bin/test_package.sh .",
15-
"lint": "biome lint --write",
16-
"format": "biome format --write",
17-
"check-lint": "biome lint",
18-
"check-format": "biome format"
15+
"check": "biome check",
16+
"ci": "biome ci"
1917
},
2018
"symfony": {
2119
"controllers": {

‎src/LazyImage/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/LiveComponent/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
"build": "node ../../../bin/build_package.js .",
1313
"watch": "node ../../../bin/build_package.js . --watch",
1414
"test": "../../../bin/test_package.sh .",
15-
"lint": "biome lint --write",
16-
"format": "biome format --write",
17-
"check-lint": "biome lint",
18-
"check-format": "biome format"
15+
"check": "biome check",
16+
"ci": "biome ci"
1917
},
2018
"symfony": {
2119
"controllers": {

‎src/LiveComponent/assets/src/Component/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import BackendResponse from '../Backend/BackendResponse';
44
import { findComponents, registerComponent, unregisterComponent } from '../ComponentRegistry';
55
import HookManager from '../HookManager';
66
import ExternalMutationTracker from '../Rendering/ExternalMutationTracker';
7-
import { elementBelongsToThisComponent, getValueFromElement, htmlToElement } from '../dom_utils';
87
import { executeMorphdom } from '../morphdom';
8+
import {elementBelongsToThisComponent, getValueFromElement, htmlToElement } from '../dom_utils';
99
import { normalizeModelName } from '../string_utils';
1010
import type { ElementDriver } from './ElementDriver';
1111
import UnsyncedInputsTracker from './UnsyncedInputsTracker';

‎src/Map/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"build": "node ../../../bin/build_package.js .",
1111
"watch": "node ../../../bin/build_package.js . --watch",
1212
"test": "../../../bin/test_package.sh .",
13-
"lint": "biome lint --write",
14-
"format": "biome format --write",
15-
"check-lint": "biome lint",
16-
"check-format": "biome format"
13+
"check": "biome check",
14+
"ci": "biome ci"
1715
},
1816
"symfony": {
1917
"importmap": {

‎src/Map/src/Bridge/Google/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"build": "node ../../../../../../bin/build_package.js .",
1111
"watch": "node ../../../../../../bin/build_package.js . --watch",
1212
"test": "../../../../../../bin/test_package.sh .",
13-
"lint": "biome lint --write",
14-
"format": "biome format --write",
15-
"check-lint": "biome lint",
16-
"check-format": "biome format"
13+
"check": "biome check",
14+
"ci": "biome ci"
1715
},
1816
"symfony": {
1917
"controllers": {

‎src/Map/src/Bridge/Leaflet/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"build": "node ../../../../../../bin/build_package.js .",
1111
"watch": "node ../../../../../../bin/build_package.js . --watch",
1212
"test": "../../../../../../bin/test_package.sh .",
13-
"lint": "biome lint --write",
14-
"format": "biome format --write",
15-
"check-lint": "biome lint",
16-
"check-format": "biome format"
13+
"check": "biome check",
14+
"ci": "biome ci"
1715
},
1816
"symfony": {
1917
"controllers": {

‎src/Notify/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/React/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/StimulusBundle/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
"build": "node ../../../bin/build_package.js .",
99
"watch": "node ../../../bin/build_package.js . --watch",
1010
"test": "../../../bin/test_package.sh .",
11-
"lint": "biome lint --write",
12-
"format": "biome format --write",
13-
"check-lint": "biome lint",
14-
"check-format": "biome format"
11+
"check": "biome check",
12+
"ci": "biome ci"
1513
},
1614
"symfony": {
1715
"needsPackageAsADependency": false,

‎src/Svelte/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
"build": "node ../../../bin/build_package.js .",
99
"watch": "node ../../../bin/build_package.js . --watch",
1010
"test": "../../../bin/test_package.sh .",
11-
"lint": "biome lint --write",
12-
"format": "biome format --write",
13-
"check-lint": "biome lint",
14-
"check-format": "biome format"
11+
"check": "biome check",
12+
"ci": "biome ci"
1513
},
1614
"symfony": {
1715
"controllers": {

‎src/Swup/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/TogglePassword/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
"build": "node ../../../bin/build_package.js .",
1313
"watch": "node ../../../bin/build_package.js . --watch",
1414
"test": "../../../bin/test_package.sh .",
15-
"lint": "biome lint --write",
16-
"format": "biome format --write",
17-
"check-lint": "biome lint",
18-
"check-format": "biome format"
15+
"check": "biome check",
16+
"ci": "biome ci"
1917
},
2018
"symfony": {
2119
"controllers": {

‎src/Translator/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"importmap": {

‎src/Turbo/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"build": "node ../../../bin/build_package.js .",
1111
"watch": "node ../../../bin/build_package.js . --watch",
1212
"test": "../../../bin/test_package.sh .",
13-
"lint": "biome lint --write",
14-
"format": "biome format --write",
15-
"check-lint": "biome lint",
16-
"check-format": "biome format"
13+
"check": "biome check",
14+
"ci": "biome ci"
1715
},
1816
"symfony": {
1917
"controllers": {

‎src/Typed/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

‎src/Vue/assets/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
"build": "node ../../../bin/build_package.js .",
1010
"watch": "node ../../../bin/build_package.js . --watch",
1111
"test": "../../../bin/test_package.sh .",
12-
"lint": "biome lint --write",
13-
"format": "biome format --write",
14-
"check-lint": "biome lint",
15-
"check-format": "biome format"
12+
"check": "biome check",
13+
"ci": "biome ci"
1614
},
1715
"symfony": {
1816
"controllers": {

0 commit comments

Comments
 (0)