[Autocomplete] filter_query & max_results conflict

[ytilotti]

There is a conflict on ux-autocomplete between filter_query and max_results.

With this code, we have 50 results:

'max_results' => 50

But with this code, we have 10 results:

'filter_query' => function(QueryBuilder $qb, string $query, EntityRepository $repository) {
    if (!$query) {
        return;
    }

    $qb->andWhere('entity.name LIKE :filter OR entity.description LIKE :filter')
        ->setParameter('filter', '%'.$query.'%');
},
 'max_results' => 50

[norkunas]

filter_query is used when you manually build the query so you also must call the $queryBuilder->setMaxResults(50) not sure if that is a good DX :)

[ytilotti]

I think a PR is necessary on the doc when I see:

filter_query (default: null)
If you want to completely control the query made for the "search results", use this option.
This is incompatible with searchable_fields and max_results

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Friendly reminder that this issue exists. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.