Fixing tests by allowing for more [hash:8] wildcards

Author: weaverryan

test/functional.js

@@ -429,15 +429,15 @@ describe('Functional tests using webpack', function() {
                     ]);
 
                     webpackAssert.assertOutputFileContains(
-                        'styles.79943add.css',
+                        'styles.[hash:8].css',
                         'font-size: 50px;'
                     );
                     webpackAssert.assertManifestPathDoesNotExist(
                         'styles.js'
                     );
                     webpackAssert.assertManifestPath(
                         'styles.css',
-                        '/styles.79943add.css'
+                        '/styles.[hash:8].css'
                     );
 
                     done();
@@ -468,7 +468,7 @@ describe('Functional tests using webpack', function() {
                     );
                     webpackAssert.assertManifestPath(
                         'styles.css',
-                        '/styles.css?79943addbc894efe'
+                        '/styles.css?[hash:16]'
                     );
 
                     done();
@@ -537,7 +537,7 @@ describe('Functional tests using webpack', function() {
                     ]);
 
                 webpackAssert.assertOutputFileContains(
-                    'bg.2eff0999.css',
+                    'bg.[hash:8].css',
                     '/build/images/symfony_logo.91beba37.png'
                 );
 
@@ -1915,7 +1915,7 @@ module.exports = {
             });
         });
 
-        it('Symfony - Stimulus standard app is built correctly', function (done) {
+        it('Symfony - Stimulus standard app is built correctly', function(done) {
             const appDir = testSetup.createTestAppDir();
 
             const version = packageHelper.getPackageVersion('@symfony/stimulus-bridge');

test/helpers/assert.js

@@ -31,6 +31,23 @@ const readOutputFile = function(webpackConfig, filePath) {
     return fs.readFileSync(fullPath, 'utf8');
 };
 
+const getMatchedFilename = function(targetDirectory, filenameRegex) {
+    const actualFiles = fs.readdirSync(targetDirectory);
+    let foundFile = false;
+    actualFiles.forEach((actualFile) => {
+        // filter out directories
+        if (fs.statSync(path.join(targetDirectory, actualFile)).isDirectory()) {
+            return;
+        }
+
+        if (actualFile.match(filenameRegex)) {
+            foundFile = actualFile;
+        }
+    });
+
+    return foundFile;
+};
+
 /**
  * Returns a regex to use to match this filename
  *
@@ -61,12 +78,17 @@ class Assert {
     }
 
     assertOutputFileContains(filePath, expectedContents) {
-        const fullPath = path.join(this.webpackConfig.outputPath, filePath);
+        const actualFilename = getMatchedFilename(
+            this.webpackConfig.outputPath,
+            convertFilenameToMatcher(filePath)
+        );
 
-        if (!fs.existsSync(fullPath)) {
+        if (false === actualFilename) {
             throw new Error(`Output file "${filePath}" does not exist.`);
         }
 
+        const fullPath = path.join(this.webpackConfig.outputPath, actualFilename);
+
         const actualContents = fs.readFileSync(fullPath, 'utf8');
         if (!actualContents.includes(expectedContents)) {
             throw new Error(`Expected contents "${expectedContents}" not found in file ${fullPath}`);