Skip to content

Commit 46a8c59

Browse files
committed
feature #889 bumping preset-env to version that depends on @babel/plugin-proposal-class-properties (weaverryan)
This PR was merged into the main branch. Discussion ---------- bumping preset-env to version that depends on @babel/plugin-proposal-class-properties This helps fix symfony/stimulus-bridge#16 Basically, in the Encore recipe, we add the `@babel/plugin-proposal-class-properties` plugin in `webpack.config.js`. But, this is not necessarily in the user's project. But 7.10 of `@babel/preset-env` started including this package. So it's a bit of an odd solution, as we're bumping this dependency so that users can do something simpler in userland config, but I think it's the simplest path. This is basically why most users already are able to use Stimulus (and the class properties it uses) without issues, as most people probably already have `@babel/preset-env` 7.10 or higher. Commits ------- aab1fb5 bumping preset-env to version that depends on @babel/plugin-proposal-class-properties
2 parents b1af95b + aab1fb5 commit 46a8c59

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"dependencies": {
2828
"@babel/core": "^7.7.0",
2929
"@babel/plugin-syntax-dynamic-import": "^7.0.0",
30-
"@babel/preset-env": "^7.4.0",
30+
"@babel/preset-env": "^7.10.0",
3131
"assets-webpack-plugin": "^5.1.1",
3232
"babel-loader": "^8.0.0",
3333
"chalk": "^4.0.0",

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@
747747
"@babel/helper-create-regexp-features-plugin" "^7.12.1"
748748
"@babel/helper-plugin-utils" "^7.10.4"
749749

750-
"@babel/preset-env@^7.4.0":
750+
"@babel/preset-env@^7.10.0":
751751
version "7.12.11"
752752
resolved "https://registry.yarnpkg.com/@babel/preset-env/-/preset-env-7.12.11.tgz#55d5f7981487365c93dbbc84507b1c7215e857f9"
753753
integrity sha512-j8Tb+KKIXKYlDBQyIOy4BLxzv1NUOwlHfZ74rvW+Z0Gp4/cI2IMDPBWAgWceGcE7aep9oL/0K9mlzlMGxA8yNw==

0 commit comments

Comments
 (0)