eth, les: unlock downloader peerSet if there's an error (ethereum#25546)

jtraglia · jagdeep sidhu · commit 7412339c194a · 2022-08-20T15:52:37.000-10:00
Unlock peerSet if there's an error in the downloader
diff --git a/eth/downloader/peer.go b/eth/downloader/peer.go
@@ -246,6 +246,7 @@ func (ps *peerSet) Register(p *peerConnection) error {
 	}
 	p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())
 	if err := ps.rates.Track(p.id, p.rates); err != nil {
+		ps.lock.Unlock()
 		return err
 	}
 	ps.peers[p.id] = p
diff --git a/les/downloader/peer.go b/les/downloader/peer.go
@@ -359,6 +359,7 @@ func (ps *peerSet) Register(p *peerConnection) error {
 	}
 	p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())
 	if err := ps.rates.Track(p.id, p.rates); err != nil {
+		ps.lock.Unlock()
 		return err
 	}
 	ps.peers[p.id] = p

Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,7 @@ func (ps peerSet) Register(p peerConnection) error {`
`246`	`246`	`}`
`247`	`247`	`p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())`
`248`	`248`	`if err := ps.rates.Track(p.id, p.rates); err != nil {`
	`249`	`+ ps.lock.Unlock()`
`249`	`250`	`return err`
`250`	`251`	`}`
`251`	`252`	`ps.peers[p.id] = p`
Original file line number	Diff line number	Diff line change
`@@ -359,6 +359,7 @@ func (ps peerSet) Register(p peerConnection) error {`
`359`	`359`	`}`
`360`	`360`	`p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())`
`361`	`361`	`if err := ps.rates.Track(p.id, p.rates); err != nil {`
	`362`	`+ ps.lock.Unlock()`
`362`	`363`	`return err`
`363`	`364`	`}`
`364`	`365`	`ps.peers[p.id] = p`