Skip to content

Commit 10a3a82

Browse files
committed
Add default server restart to each test run
Found that the root cause of the issues happened with vinyl tests were backside effects of the not correct test 'vinyl/gh.test.lua' which leaved Tarantool worker process in inconsistent state. After it any other next test on the same Tarantool worker process could fail on running testings with snapshots calls, like tarantool/tarantool-qa#126: error: Snapshot is already in progress Either restarting Tarantool worker process could fail on stopping it, like #261 and tarantool/tarantool#5141: E> failed to process vylog record: delete_slice{slice_id=115, } E> ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Slice 115 deleted but not registered Decided to avoid of such situations for now and in the future all tests must be run after Tarantool worker default server process was restarted. This patch moves this server restart call from check if the test failed to the common part of the tests run loop. Part of tarantool/tarantool-qa#97 Fixes #260 Fixes #261 Needed for tarantool/tarantool#5089 Closes tarantool/tarantool-qa#126
1 parent 70960b6 commit 10a3a82

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/worker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,13 +350,13 @@ def run_loop(self, task_queue, result_queue):
350350
retries_left = self.suite.fragile_retries()
351351
# let's run till short_status became 'pass'
352352
while short_status != 'pass' and retries_left >= 0:
353+
self.restart_server()
353354
# print message only after some fails occurred
354355
if short_status == 'fail':
355-
self.restart_server()
356356
color_stdout(
357357
'Test "%s", conf: "%s"\n'
358358
'\tfrom "fragile" list failed with results'
359-
' file checksum: "%s", rerunning with server restart ...\n'
359+
' file checksum: "%s", rerunning ...\n'
360360
% (task_id[0], task_id[1], result_checksum), schema='error')
361361
# run task and save the result to short_status
362362
short_status, result_checksum, duration = self.run_task(task_id)

0 commit comments

Comments
 (0)