Skip to content

Commit 5c6417f

Browse files
committed
Remove unneeded suite.ini 'pretest_clean' option
Found that all currently used suite.ini files use this option enabled. Also there is no need to have any suite of tests where snap either log files whould be used by the next test from the previous, due to such test schema can be easily implemented within single test file.
1 parent b5adf2e commit 5c6417f

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

lib/test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ def execute(self, server):
151151
# Note: don't forget to set 'server.current_test = self' in
152152
# inherited classes. Crash reporting relying on that.
153153
server.current_test = self
154-
if self.suite_ini['pretest_clean']:
155-
server.pretest_clean()
154+
# All the test runs must be isolated between each other on each worker.
155+
server.pretest_clean()
156156

157157
def run(self, server):
158158
""" Execute the test assuming it's a python program. If the test

lib/test_suite.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ def __init__(self, suite_path, args):
136136
# use old format dictionary
137137
self.fragile['tests'] = self.ini['fragile']
138138

139-
self.parse_bool_opt('pretest_clean', False)
140139
self.parse_bool_opt('use_unix_sockets', False)
141140
self.parse_bool_opt('use_unix_sockets_iproto', False)
142141
self.parse_bool_opt('is_parallel', False)

test/test-app/suite.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
core = app
33
description = application tests
44
is_parallel = True
5-
pretest_clean = True
65
use_unix_sockets_iproto = True

test/test-tarantool/suite.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ core = tarantool
33
description = tarantool tests
44
script = box.lua
55
use_unix_sockets = True
6-
pretest_clean = True
76
config = engine.cfg

0 commit comments

Comments
 (0)