From af8ce5420628a97a58742f964c754e58be0ae8ca Mon Sep 17 00:00:00 2001 From: gabrieldemarmiesse Date: Tue, 3 Mar 2020 11:29:33 +0100 Subject: [PATCH 1/5] Run linux tests before building the wheel. --- tools/ci_build/builds/release_linux.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/ci_build/builds/release_linux.sh b/tools/ci_build/builds/release_linux.sh index d08d90f32f..97072fe8ee 100755 --- a/tools/ci_build/builds/release_linux.sh +++ b/tools/ci_build/builds/release_linux.sh @@ -43,6 +43,12 @@ python3 -m pip install --upgrade setuptools python3 --version python3 ./configure.py +## Run bazel test command. Double test timeouts to avoid flakes. +bazel test -c opt -k \ + --jobs=${N_JOBS} --test_timeout 300,450,1200,3600 \ + --test_output=errors --local_test_jobs=8 \ + //tensorflow_addons/... + # Build bazel build \ -c opt \ From d7f6a9778dd2295bf083c2f0064a952442981422 Mon Sep 17 00:00:00 2001 From: gabrieldemarmiesse Date: Tue, 3 Mar 2020 11:31:48 +0100 Subject: [PATCH 2/5] Remove old tests. --- .github/workflows/release.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5c1a4af78b..b98b761a47 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,15 +20,6 @@ env: BAZEL_VERSION: 1.1.0 jobs: - manylinux-cpu-release-test: - name: Test release on Ubuntu - runs-on: ubuntu-18.04 - steps: - - uses: actions/checkout@v2 - - name: Release test Ubuntu - run: | - set -x -e - bash tools/run_cpu_tests.sh release-wheel: name: Build release wheels runs-on: ${{ matrix.os }} @@ -59,7 +50,7 @@ jobs: upload-wheels: name: Publish wheels to PyPi - needs: [release-wheel, manylinux-cpu-release-test] + needs: [release-wheel] runs-on: ubuntu-18.04 steps: - uses: actions/download-artifact@v1 From 6e85e376a4b6d5c26ec3ea416340cc4dfe895c26 Mon Sep 17 00:00:00 2001 From: gabrieldemarmiesse Date: Tue, 3 Mar 2020 11:47:47 +0100 Subject: [PATCH 3/5] fix variable --- tools/ci_build/builds/release_linux.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ci_build/builds/release_linux.sh b/tools/ci_build/builds/release_linux.sh index 97072fe8ee..3c42e966ca 100755 --- a/tools/ci_build/builds/release_linux.sh +++ b/tools/ci_build/builds/release_linux.sh @@ -45,7 +45,7 @@ python3 ./configure.py ## Run bazel test command. Double test timeouts to avoid flakes. bazel test -c opt -k \ - --jobs=${N_JOBS} --test_timeout 300,450,1200,3600 \ + --jobs=auto --test_timeout 300,450,1200,3600 \ --test_output=errors --local_test_jobs=8 \ //tensorflow_addons/... From a6aa17e837acbd2fdeb755cf827283f3450eec03 Mon Sep 17 00:00:00 2001 From: Gabriel de Marmiesse Date: Thu, 5 Mar 2020 11:48:32 +0100 Subject: [PATCH 4/5] Use --crosstool_top Co-Authored-By: Sean Morgan --- tools/ci_build/builds/release_linux.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ci_build/builds/release_linux.sh b/tools/ci_build/builds/release_linux.sh index 3c42e966ca..39c4c96704 100755 --- a/tools/ci_build/builds/release_linux.sh +++ b/tools/ci_build/builds/release_linux.sh @@ -47,6 +47,7 @@ python3 ./configure.py bazel test -c opt -k \ --jobs=auto --test_timeout 300,450,1200,3600 \ --test_output=errors --local_test_jobs=8 \ + --crosstool_top=//build_deps/toolchains/gcc7_manylinux2010-nvcc-cuda10.1:toolchain \ //tensorflow_addons/... # Build From 486b2fd5188eb905ac6bcb0611a38257f5e9cc2e Mon Sep 17 00:00:00 2001 From: gabrieldemarmiesse Date: Thu, 5 Mar 2020 11:50:56 +0100 Subject: [PATCH 5/5] Don't depend on test that doesn't exist. --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a8e863fda1..4217a97d84 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -74,7 +74,7 @@ jobs: upload-wheels: name: Publish wheels to PyPi - needs: [release-wheel, test-release-wheel, manylinux-cpu-release-test] + needs: [release-wheel, test-release-wheel] runs-on: ubuntu-18.04 strategy: matrix: