Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed issue with v2, and issue with losing modified date/time. #203

Closed
Nurple opened this issue Apr 6, 2022 · 9 comments
Closed

Speed issue with v2, and issue with losing modified date/time. #203

Nurple opened this issue Apr 6, 2022 · 9 comments

Comments

@Nurple
Copy link

Nurple commented Apr 6, 2022

Heya,

I updated my config for v2 and noticed there's a big diffence in speed, what took a few seconds in v1 is taking minutes in v2, also the modified date/time gets changed to the current time.

I'm probably doing something wrong in my config.

Expected behavior:
Speed of task to be the same, and not have the modified date/time be changed to the current time.

Environment:

  • OS: Windows 10 - 21H2 - x64
  • Python Version: v3.10.3
  • Organize Version: v2.1.2

Your config file

rules:
  - locations: "D:/GoPro/"
    subfolders: true
    filters:
      - extension:
          - mp4
      - lastmodified
    actions:
      - move: "D:/GoPro Sorted/{lastmodified.strftime('%Y-%m-%d')}/"
@Nurple Nurple added the bug label Apr 6, 2022
@tfeldmann
Copy link
Owner

Hey, you're hitting an unoptimized code path in the underlyingpyfilesystem library. I submitted a PR to pyfilesystem which should fix this (PyFilesystem/pyfilesystem2#523). So this should be fixed as soon as they do a new release.

@Nurple
Copy link
Author

Nurple commented May 7, 2022

Oh OK, thanks for letting me know, and thanks for the app :)

@tfeldmann
Copy link
Owner

PyFilesystem did release a new version and this should be fixed now. Can you check again? Please make sure to run pip3 install -U fs before or install the latest organize version.

@Nurple
Copy link
Author

Nurple commented Aug 26, 2022

Edit:
Seems I was wrong, speed issue isn't fixed, guess the files I tested were still in ram.

The latest version of fs on pypi.org is 2.4.16 (Released: May 2, 2022), so that makes sense.


Heya, sorry for the late reply.

Just checked and the speed issue seems to be fixed now, but the issue with the modified date/time is still there though.

@tfeldmann tfeldmann reopened this Aug 30, 2022
@vipsbpig
Copy link

vipsbpig commented Nov 2, 2022

It also confuse me a lot.

@stantyan
Copy link

Hi and thank you for a great tool. Does anyone know how to fix the issue with modified/create datetime changed to current on copy/move actions?

@tfeldmann tfeldmann added this to the v3 milestone Nov 10, 2023
@tfeldmann
Copy link
Owner

I just released v3 as a pre-release (infos in the repo's readme).

The speed issues and strange metadata issues came from the pyfilesystem library which is now removed completely.
@Nurple running your config should take seconds again!

@Nurple
Copy link
Author

Nurple commented Feb 4, 2024

Heya, sorry for late reply, all seems fine now. Thanks.

@tfeldmann
Copy link
Owner

Np, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants