Simulator: make _fetch_{metadata,target} public

Make _fetch_metadata and _fetch_taget public by renaming them to
fetch_metadata and fetch_target.
This will allow the removal of multiple pylint disables because of
"accessing private members".

Signed-off-by: Martin Vrachev <mvrachev@vmware.com>

Author: MVrachev

tests/repository_simulator.py

@@ -206,7 +206,7 @@ def fetch(self, url: str) -> Iterator[bytes]:
                 role = ver_and_name
                 version = None
 
-            yield self._fetch_metadata(role, version)
+            yield self.fetch_metadata(role, version)
         elif path.startswith("/targets/"):
             # figure out target path and hash prefix
             target_path = path[len("/targets/") :]
@@ -218,11 +218,11 @@ def fetch(self, url: str) -> Iterator[bytes]:
                 prefix, _, filename = prefixed_filename.partition(".")
             target_path = f"{dir_parts}{sep}{filename}"
 
-            yield self._fetch_target(target_path, prefix)
+            yield self.fetch_target(target_path, prefix)
         else:
             raise FetcherHTTPError(f"Unknown path '{path}'", 404)
 
-    def _fetch_target(
+    def fetch_target(
         self, target_path: str, target_hash: Optional[str]
     ) -> bytes:
         """Return data for 'target_path', checking 'target_hash' if it is given.
@@ -241,9 +241,7 @@ def _fetch_target(
         logger.debug("fetched target %s", target_path)
         return repo_target.data
 
-    def _fetch_metadata(
-        self, role: str, version: Optional[int] = None
-    ) -> bytes:
+    def fetch_metadata(self, role: str, version: Optional[int] = None) -> bytes:
         """Return signed metadata for 'role', using 'version' if it is given.
 
         If version is None, non-versioned metadata is being requested.
@@ -284,7 +282,7 @@ def _fetch_metadata(
     def _compute_hashes_and_length(
         self, role: str
     ) -> Tuple[Dict[str, str], int]:
-        data = self._fetch_metadata(role)
+        data = self.fetch_metadata(role)
         digest_object = sslib_hash.digest(sslib_hash.DEFAULT_HASH_ALGORITHM)
         digest_object.update(data)
         hashes = {sslib_hash.DEFAULT_HASH_ALGORITHM: digest_object.hexdigest()}
@@ -375,12 +373,12 @@ def write(self) -> None:
 
         for ver in range(1, len(self.signed_roots) + 1):
             with open(os.path.join(dest_dir, f"{ver}.root.json"), "wb") as f:
-                f.write(self._fetch_metadata(Root.type, ver))
+                f.write(self.fetch_metadata(Root.type, ver))
 
         for role in [Timestamp.type, Snapshot.type, Targets.type]:
             with open(os.path.join(dest_dir, f"{role}.json"), "wb") as f:
-                f.write(self._fetch_metadata(role))
+                f.write(self.fetch_metadata(role))
 
         for role in self.md_delegates:
             with open(os.path.join(dest_dir, f"{role}.json"), "wb") as f:
-                f.write(self._fetch_metadata(role))
+                f.write(self.fetch_metadata(role))

tests/test_updater_consistent_snapshot.py

@@ -121,9 +121,8 @@ def test_top_level_roles_update(
         sim = self._init_repo(consistent_snapshot)
         updater = self._init_updater(sim)
 
-        # pylint: disable=protected-access
         with patch.object(
-            sim, "_fetch_metadata", wraps=sim._fetch_metadata
+            sim, "fetch_metadata", wraps=sim.fetch_metadata
         ) as wrapped_fetch:
             updater.refresh()
 
@@ -166,9 +165,8 @@ def test_delegated_roles_update(
         updater = self._init_updater(sim)
         updater.refresh()
 
-        # pylint: disable=protected-access
         with patch.object(
-            sim, "_fetch_metadata", wraps=sim._fetch_metadata
+            sim, "fetch_metadata", wraps=sim.fetch_metadata
         ) as wrapped_fetch:
             # trigger updater to fetch the delegated metadata
             updater.get_targetinfo("anything")
@@ -218,9 +216,8 @@ def test_download_targets(self, test_case_data: Dict[str, Any]) -> None:
         updater.config.prefix_targets_with_hash = prefix_targets_with_hash
         updater.refresh()
 
-        # pylint: disable=protected-access
         with patch.object(
-            sim, "_fetch_target", wraps=sim._fetch_target
+            sim, "fetch_target", wraps=sim.fetch_target
         ) as wrapped_fetch_target:
 
             for targetpath in targetpaths:

tests/test_updater_top_level_update.py

@@ -90,8 +90,7 @@ def _assert_content_equals(
         self, role: str, version: Optional[int] = None
     ) -> None:
         """Assert that local file content is the expected"""
-        # pylint: disable=protected-access
-        expected_content = self.sim._fetch_metadata(role, version)
+        expected_content = self.sim.fetch_metadata(role, version)
         with open(os.path.join(self.metadata_dir, f"{role}.json"), "rb") as f:
             self.assertEqual(f.read(), expected_content)