Skip to content

ngclient: max_root_rotations value is very small #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuagl opened this issue Sep 10, 2021 · 1 comment
Open

ngclient: max_root_rotations value is very small #1577

joshuagl opened this issue Sep 10, 2021 · 1 comment
Labels
discussion Discussions related to the design, implementation and operation of the project ngclient

Comments

@joshuagl
Copy link
Member

Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.

Description of issue or feature request:

ngclient (like legacy client?) has a max_root_rotations value of 32, which feels low.

The specification suggests a value of 1024 (2^10)

Can we define a way of calculating a sane default for, i.e., PyPI users and update the default accordingly?

@mnm678
Copy link
Contributor

mnm678 commented Sep 10, 2021

Per PEP 458, root metadata should expire every year, so we'll want this value to be at least the number of years we anticipate clients will go between updating their local root metadata, plus some extra rotations in case of a compromise. I actually think that 32 should be plenty.

@lukpueh lukpueh added the discussion Discussions related to the design, implementation and operation of the project label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions related to the design, implementation and operation of the project ngclient
Projects
None yet
Development

No branches or pull requests

3 participants